Skip to content

Commit 286e395

Browse files
authored
Detect Django template URLs
Django URLs are currently not detected, but flask and nunjucks URL are. (See #12267)
1 parent 298c6b5 commit 286e395

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

javascript/ql/src/DOM/TargetBlank.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@ predicate hasDynamicHrefHostAttributeValue(DOM::ElementDefinition elem) {
4444
// ... that does not start with a fixed host or a relative path (common formats)
4545
not url.regexpMatch("(?i)((https?:)?//)?[-a-z0-9.]*/.*") and
4646
// .. that is not a call to `url_for` in a Flask / nunjucks application
47-
not url.regexpMatch("\\{\\{\\s*url(_for)?\\(.+\\).*")
47+
not url.regexpMatch("\\{\\{\\s*url(_for)?\\(.+\\).*") and
48+
// .. that is not a call to `url` in a Django application
49+
not url.regexpMatch("\\{%\\s*url.*")
4850
)
4951
)
5052
}

0 commit comments

Comments
 (0)