Dataflow: Fix missing join on summaryLabel.

aschackmull · aschackmull · commit 2c591f5420c2 · 2024-08-15T11:05:08.000+02:00
diff --git a/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll b/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
@@ -4350,7 +4350,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
 
       private PathNodeMid getSuccMid(string label) {
         pathStep(this, result.getNodeEx(), result.getState(), result.getCallContext(),
-          result.getSummaryCtx(), result.getType(), result.getAp(), _, label)
+          result.getSummaryCtx(), result.getType(), result.getAp(), result.getSummaryLabel(), label)
       }
 
       private predicate isSourceWithLabel(string labelprefix) {

Original file line number	Diff line number	Diff line change
`@@ -4350,7 +4350,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {`
`4350`	`4350`
`4351`	`4351`	`private PathNodeMid getSuccMid(string label) {`
`4352`	`4352`	`pathStep(this, result.getNodeEx(), result.getState(), result.getCallContext(),`
`4353`		`- result.getSummaryCtx(), result.getType(), result.getAp(), _, label)`
	`4353`	`+ result.getSummaryCtx(), result.getType(), result.getAp(), result.getSummaryLabel(), label)`
`4354`	`4354`	`}`
`4355`	`4355`
`4356`	`4356`	`private predicate isSourceWithLabel(string labelprefix) {`