C++: Drive-by cleanup: This case is redundant since a 'DestructorCall' is also a 'FunctionCall'.

MathiasVP · MathiasVP · commit 2c5f65a241b2 · 2023-12-15T11:38:52.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/Function.qll b/cpp/ql/lib/semmle/code/cpp/Function.qll
@@ -339,10 +339,6 @@ class Function extends Declaration, ControlFlowNode, AccessHolder, @function {
     exists(FunctionCall call |
       call.getEnclosingFunction() = this and call.getTarget() = f and call = l
     )
-    or
-    exists(DestructorCall call |
-      call.getEnclosingFunction() = this and call.getTarget() = f and call = l
-    )
   }
 
   /** Holds if this function accesses a function or variable or enumerator `a`. */

Original file line number	Diff line number	Diff line change
`@@ -339,10 +339,6 @@ class Function extends Declaration, ControlFlowNode, AccessHolder, @function {`
`339`	`339`	`exists(FunctionCall call \|`
`340`	`340`	`call.getEnclosingFunction() = this and call.getTarget() = f and call = l`
`341`	`341`	`)`
`342`		`- or`
`343`		`- exists(DestructorCall call \|`
`344`		`- call.getEnclosingFunction() = this and call.getTarget() = f and call = l`
`345`		`- )`
`346`	`342`	`}`
`347`	`343`
`348`	`344`	/** Holds if this function accesses a function or variable or enumerator `a`. */