remove redundant cast

erik-krogh · erik-krogh · commit 2f1bd75ee923 · 2025-01-21T09:51:14.000+01:00
diff --git a/javascript/ql/src/Security/CWE-020/IncorrectSuffixCheck.ql b/javascript/ql/src/Security/CWE-020/IncorrectSuffixCheck.ql
@@ -58,7 +58,7 @@ class IndexOfCall extends DataFlow::MethodCallNode {
       // both use the same concatenation of a string and a value
       exists(Expr origin, StringLiteral str, AddExpr otherAdd |
         this.getArgument(0).asExpr().(AddExpr).hasOperands(origin, str) and
-        otherAdd = result.getArgument(0).asExpr().(AddExpr)
+        otherAdd = result.getArgument(0).asExpr()
       |
         otherAdd.getAnOperand().(StringLiteral).getStringValue() = str.getStringValue() and
         otherAdd.getAnOperand().flow().getALocalSource() = origin.flow().getALocalSource()

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ class IndexOfCall extends DataFlow::MethodCallNode {`
`58`	`58`	`// both use the same concatenation of a string and a value`
`59`	`59`	`exists(Expr origin, StringLiteral str, AddExpr otherAdd \|`
`60`	`60`	`this.getArgument(0).asExpr().(AddExpr).hasOperands(origin, str) and`
`61`		`- otherAdd = result.getArgument(0).asExpr().(AddExpr)`
	`61`	`+ otherAdd = result.getArgument(0).asExpr()`
`62`	`62`	`\|`
`63`	`63`	`otherAdd.getAnOperand().(StringLiteral).getStringValue() = str.getStringValue() and`
`64`	`64`	`otherAdd.getAnOperand().flow().getALocalSource() = origin.flow().getALocalSource()`