Consolidate application mode tests.

Author: Max Schaefer

java/ql/automodel/test/AutomodelApplicationModeExtraction/AutomodelApplicationModeExtractCandidates.ql

@@ -0,0 +1,47 @@
+import java
+import AutomodelApplicationModeCharacteristics
+import TestUtilities.InlineExpectationsTest
+
+module Extraction implements TestSig {
+  string getARelevantTag() {
+    result in ["sourceModel", "sinkModel", "positiveExample", "negativeExample"]
+  }
+
+  additional predicate selectEndpoint(
+    Endpoint endpoint, string name, string signature, string input, string output,
+    string extensibleType, string tag, string suffix
+  ) {
+    isCandidate(endpoint, _, _, _, name, signature, input, output, _, extensibleType, _) and
+    tag = extensibleType and
+    suffix = ""
+    or
+    isNegativeExample(endpoint, _, _, _, _, _, name, signature, input, output, _, extensibleType) and
+    tag = "negativeExample" and
+    suffix = ""
+    or
+    exists(string endpointType |
+      isPositiveExample(endpoint, endpointType, _, _, _, name, signature, input, output, _,
+        extensibleType) and
+      tag = "positiveExample" and
+      suffix = "(" + endpointType + ")"
+    )
+  }
+
+  predicate hasActualResult(Location location, string element, string tag, string value) {
+    exists(
+      Endpoint endpoint, string name, string signature, string input, string output,
+      string extensibleType, string suffix
+    |
+      selectEndpoint(endpoint, name, signature, input, output, extensibleType, tag, suffix)
+    |
+      endpoint.asTop().getLocation() = location and
+      endpoint.toString() = element and
+      // for source models only the output is relevant, and vice versa for sink models
+      if extensibleType = "sourceModel"
+      then value = name + signature + ":" + output + suffix
+      else value = name + signature + ":" + input + suffix
+    )
+  }
+}
+
+import MakeTest<Extraction>

java/ql/automodel/test/AutomodelApplicationModeExtraction/AutomodelApplicationModeExtractNegativeExamples.expected

@@ -87,9 +87,9 @@ public FutureTask getTask() {
 class MoreTests {
 	public static void FilesListExample(Path p) throws Exception {
 		Files.list(
-			Files.createDirectories( // $ negativeExample=list(Path):Argument[0] // modeled as a flow step
+			Files.createDirectories(
 				p // $ positiveExample=createDirectories(Path,FileAttribute[]):Argument[0](path-injection)
-			) // $ sourceModel=createDirectories(Path,FileAttribute[]):ReturnValue
+			) // $ sourceModel=createDirectories(Path,FileAttribute[]):ReturnValue negativeExample=list(Path):Argument[0] // modeled as a flow step
 		); // $ sourceModel=list(Path):ReturnValue
 
 		Files.delete(