C++: Reduce number of regexps.

geoffw0 · geoffw0 · commit 316117f5c9f5 · 2023-01-13T18:50:41.000Z
diff --git a/cpp/ql/src/Security/CWE/CWE-290/AuthenticationBypass.ql b/cpp/ql/src/Security/CWE/CWE-290/AuthenticationBypass.ql
@@ -34,7 +34,7 @@ predicate hardCodedAddressOrIP(StringLiteral txt) {
     s.matches("\"www.%\"") or
     s.matches("\"http:%\"") or
     s.matches("\"https:%\"") or
-    s.regexpMatch("\".*\\." + getATopLevelDomain() + "\"")
+    s.regexpMatch("\".*\\.(" + concat(getATopLevelDomain(), "|") + ")\"")
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ predicate hardCodedAddressOrIP(StringLiteral txt) {`
`34`	`34`	`s.matches("\"www.%\"") or`
`35`	`35`	`s.matches("\"http:%\"") or`
`36`	`36`	`s.matches("\"https:%\"") or`
`37`		`- s.regexpMatch("\".*\\." + getATopLevelDomain() + "\"")`
	`37`	`+ s.regexpMatch("\".*\\.(" + concat(getATopLevelDomain(), "\|") + ")\"")`
`38`	`38`	`)`
`39`	`39`	`}`
`40`	`40`