Strengthen the type of SetterMethodCall

hvitved · hvitved · commit 317303cdada2 · 2021-09-27T14:05:28.000+02:00
diff --git a/ql/lib/codeql/ruby/ast/Call.qll b/ql/lib/codeql/ruby/ast/Call.qll
@@ -123,7 +123,7 @@ class MethodCall extends Call, TMethodCall {
  * a[0] = 10
  * ```
  */
-class SetterMethodCall extends MethodCall {
+class SetterMethodCall extends MethodCall, TMethodCallSynth {
   SetterMethodCall() { this = TMethodCallSynth(_, _, _, true, _) }
 
   final override string getAPrimaryQlClass() { result = "SetterMethodCall" }
diff --git a/ql/lib/codeql/ruby/typetracking/TypeTrackerSpecific.qll b/ql/lib/codeql/ruby/typetracking/TypeTrackerSpecific.qll
@@ -105,7 +105,6 @@ predicate basicStoreStep(Node nodeFrom, DataFlowPublic::LocalSourceNode nodeTo,
  */
 private string getSetterCallAttributeName(AST::SetterMethodCall call) {
   // TODO: this should be exposed in `SetterMethodCall`
-  not call instanceof AST::ElementReference and
   exists(string setterName |
     setterName = call.getMethodName() and result = setterName.prefix(setterName.length() - 1)
   )

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,6 @@ predicate basicStoreStep(Node nodeFrom, DataFlowPublic::LocalSourceNode nodeTo,`
`105`	`105`	`*/`
`106`	`106`	`private string getSetterCallAttributeName(AST::SetterMethodCall call) {`
`107`	`107`	// TODO: this should be exposed in `SetterMethodCall`
`108`		`- not call instanceof AST::ElementReference and`
`109`	`108`	`exists(string setterName \|`
`110`	`109`	`setterName = call.getMethodName() and result = setterName.prefix(setterName.length() - 1)`
`111`	`110`	`)`