remove some benign results from ql/suggest-instanceof-extension

erik-krogh · erik-krogh · commit 35f9f7c71b17 · 2022-12-14T14:47:58.000+01:00
diff --git a/ql/ql/src/codeql_ql/style/UseInstanceofExtensionQuery.qll b/ql/ql/src/codeql_ql/style/UseInstanceofExtensionQuery.qll
@@ -14,7 +14,9 @@ predicate instanceofThisInCharPred(Class c, Type type) {
   |
     instanceOf.getExpr() instanceof ThisAccess and
     type = instanceOf.getType().getResolvedType()
-  )
+  ) and
+  // no existing super-type corresponds to the instanceof type, that is benign.
+  not c.getASuperType().getResolvedType() = type
 }
 
 /** Gets an inline cast that cases `this` to `type` inside a class predicate for `c`. */

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,9 @@ predicate instanceofThisInCharPred(Class c, Type type) {`
`14`	`14`	`\|`
`15`	`15`	`instanceOf.getExpr() instanceof ThisAccess and`
`16`	`16`	`type = instanceOf.getType().getResolvedType()`
`17`		`- )`
	`17`	`+ ) and`
	`18`	`+ // no existing super-type corresponds to the instanceof type, that is benign.`
	`19`	`+ not c.getASuperType().getResolvedType() = type`
`18`	`20`	`}`
`19`	`21`
`20`	`22`	/** Gets an inline cast that cases `this` to `type` inside a class predicate for `c`. */