C++: Address review comments.

criemen · criemen · commit 39a7d3decc4b · 2021-03-19T11:23:47.000+01:00
diff --git a/cpp/ql/src/Diagnostics/FailedExtractions.qll b/cpp/ql/src/Diagnostics/FailedExtractions.qll
@@ -84,10 +84,7 @@ class ExtractionUnrecoverableError extends ExtractionError, TCompilationFailed {
     result = "Unrecoverable extraction error while compiling " + f.toString()
   }
 
-  override string getErrorMessage() {
-    result =
-      "Unrecoverable compilation failure; check logs/build-tracer.log in the database directory for more information."
-  }
+  override string getErrorMessage() { result = "unrecoverable compilation failure." }
 
   override File getFile() { result = f }
 
diff --git a/cpp/ql/src/Diagnostics/FailedInvocations.ql b/cpp/ql/src/Diagnostics/FailedInvocations.ql
@@ -1,8 +1,8 @@
 /**
- * @name Aborted extractor invocations
+ * @name Failed extractor invocations
  * @description Gives the command line of compilations for which extraction did not run to completion.
  * @kind diagnostic
- * @id cpp/diagnostics/aborted-extractions
+ * @id cpp/diagnostics/failed-extractor-invocations
  */
 
 import cpp

Original file line number	Diff line number	Diff line change
`@@ -84,10 +84,7 @@ class ExtractionUnrecoverableError extends ExtractionError, TCompilationFailed {`
`84`	`84`	`result = "Unrecoverable extraction error while compiling " + f.toString()`
`85`	`85`	`}`
`86`	`86`
`87`		`- override string getErrorMessage() {`
`88`		`- result =`
`89`		`- "Unrecoverable compilation failure; check logs/build-tracer.log in the database directory for more information."`
`90`		`- }`
	`87`	`+ override string getErrorMessage() { result = "unrecoverable compilation failure." }`
`91`	`88`
`92`	`89`	`override File getFile() { result = f }`
`93`	`90`