Skip to content

Commit 3a30f58

Browse files
committed
Address review comments
1 parent 400802c commit 3a30f58

File tree

4 files changed

+144
-151
lines changed

4 files changed

+144
-151
lines changed

ruby/ql/lib/codeql/ruby/ApiGraphs.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ module API {
9898
/**
9999
* Gets a `new` call to the function represented by this API component.
100100
*/
101-
DataFlow::ExprNode getAnInstantiation() { result = getInstance().getAnImmediateUse() }
101+
DataFlow::ExprNode getAnInstantiation() { result = this.getInstance().getAnImmediateUse() }
102102

103103
/**
104104
* Gets a node representing a subclass of the class represented by this node.

ruby/ql/lib/codeql/ruby/frameworks/StandardLibrary.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1110,8 +1110,8 @@ module Array {
11101110
}
11111111
}
11121112

1113-
private class InitializeCopySummary extends SimpleSummarizedCallable {
1114-
InitializeCopySummary() { this = "initialize_copy" }
1113+
private class ReplaceSummary extends SimpleSummarizedCallable {
1114+
ReplaceSummary() { this = "replace" }
11151115

11161116
override predicate propagatesFlowExt(string input, string output, boolean preservesValue) {
11171117
(

0 commit comments

Comments
 (0)