Skip to content

Commit 3d9243d

Browse files
author
Felicity Chapman
authored
Update analysis-java.md
I started writing review comments to suggest simplifications to the text/tense, but thought that this might be clearer. Feel free to close and simplify using alternative wording.
1 parent 9b530e4 commit 3d9243d

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

change-notes/1.20/analysis-java.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,13 @@
1818
## Changes to QL libraries
1919

2020
* The class `ControlFlowNode` (and by extension `BasicBlock`) is no longer
21-
directly equatable to `Expr` and `Stmt`. Any queries that have been
22-
exploiting these equalities, for example by using casts, will need minor
23-
updates in order to fix any compilation errors. Conversions can be inserted
24-
in either direction depending on what is most convenient. Available
25-
conversions include `Expr.getControlFlowNode()`, `Stmt.getControlFlowNode()`,
26-
`ControlFlowNode.asExpr()`, `ControlFlowNode.asStmt()`, and
27-
`ControlFlowNode.asCall()`. Exit nodes were until now modelled as a
28-
`ControlFlowNode` equal to its enclosing `Callable`; these are now instead
29-
modelled by the class `ControlFlow::ExitNode`.
30-
21+
directly equatable to `Expr` and `Stmt`. Any queries that exploit these
22+
equalities, for example by using casts, will now report compilation errors.
23+
You can fix these errors by making minor changes to the affected classes.
24+
The conversion can be inserted in either direction depending on what is most
25+
convenient. Available conversions include `Expr.getControlFlowNode()`,
26+
`Stmt.getControlFlowNode()`, `ControlFlowNode.asExpr()`,
27+
`ControlFlowNode.asStmt()`, and `ControlFlowNode.asCall()`.
28+
Exit nodes were until now modeled as a `ControlFlowNode` equal to its
29+
enclosing `Callable`; these are now modeled by the class `ControlFlow::ExitNode`.
3130

0 commit comments

Comments
 (0)