Fix failing checks

joefarebrother · joefarebrother · commit 3e3503a76396 · 2021-10-20T17:25:38.000+01:00
diff --git a/java/ql/lib/semmle/code/java/security/AndroidSensitiveCommunicationQuery.qll b/java/ql/lib/semmle/code/java/security/AndroidSensitiveCommunicationQuery.qll
@@ -122,7 +122,7 @@ private predicate isStartActivityOrServiceSink(DataFlow::Node arg) {
   )
 }
 
-predicate isCleanIntent(Expr intent) {
+private predicate isCleanIntent(Expr intent) {
   intent.getType() instanceof TypeIntent and
   (
     exists(MethodAccess setRecieverMa |
diff --git a/java/ql/src/Security/CWE/CWE-927/SensitiveCommunication.qhelp b/java/ql/src/Security/CWE/CWE-927/SensitiveCommunication.qhelp
@@ -16,7 +16,7 @@
 
   <example>
     <p>The following example shows two ways of broadcasting intents. In the 'BAD' case, no "receiver permission" is specified. In the 'GOOD' case, "receiver permission" or "receiver application" is specified.</p>
-    <sample src="SensitiveBroadcast.java" />
+    <sample src="SensitiveCommunication.java" />
   </example>
 
   <references>

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ private predicate isStartActivityOrServiceSink(DataFlow::Node arg) {`
`122`	`122`	`)`
`123`	`123`	`}`
`124`	`124`
`125`		`-predicate isCleanIntent(Expr intent) {`
	`125`	`+private predicate isCleanIntent(Expr intent) {`
`126`	`126`	`intent.getType() instanceof TypeIntent and`
`127`	`127`	`(`
`128`	`128`	`exists(MethodAccess setRecieverMa \|`