Skip to content

Commit 3f37fe6

Browse files
Apply suggestions from code review - docs and wording
Docs suggestions accepted, thank you 🙏 Co-authored-by: Felicity Chapman <[email protected]>
1 parent d71be8a commit 3f37fe6

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

javascript/ql/src/Security/CWE-830/FunctionalityFromUntrustedDomain.qhelp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,12 @@
4444
</p>
4545

4646
<p>
47-
To help mitigate future risk of including a script that could be compromised, consider whether you need to
48-
use a polyfill or other library at all. Modern browsers do not require a polyfill, and other popular libraries are redundant after enhancements to HTML 5.
47+
To help mitigate the risk of including a script that could be compromised in the future, consider whether you need to
48+
use polyfill or another library at all. Modern browsers do not require a polyfill, and other popular libraries were made redundant by enhancements to HTML 5.
4949
</p>
5050

5151
<p>
52-
If you do need a polyfill service or library, move to using a trusted CDN.
52+
If you do need a polyfill service or library, move to using a CDN that you trust.
5353
</p>
5454

5555
<p>
@@ -59,7 +59,7 @@
5959

6060
A dynamic service cannot be easily used with SRI. Nevertheless,
6161
it is possible to list multiple acceptable SHA hashes in the <code>integrity</code> attribute,
62-
such as those for the content generated for major browers used by your users.
62+
such as hashes for the content required for the major browsers used by your users.
6363
</p>
6464

6565
<p>
@@ -81,7 +81,7 @@
8181
<sample src="polyfill-trusted.html" />
8282

8383
<p>
84-
If you can investigate the most used browsers by your users, you can list the hashes of the polyfills for those browsers:
84+
If you know which browsers are used by the majority of your users, you can list the hashes of the polyfills for those browsers:
8585
</p>
8686

8787
<sample src="polyfill-sri.html" />

javascript/ql/src/Security/CWE-830/FunctionalityFromUntrustedDomain.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* @name Untrusted domain used in script or other content
3-
* @description Use of a script or other content from an untrusted or compromised domain
3+
* @description Using a resource from an untrusted or compromised domain makes your code vulnerable to receiving malicious code.
44
* @kind problem
55
* @security-severity 7.2
66
* @problem.severity error

0 commit comments

Comments
 (0)