Update cpp/ql/src/experimental/Security/CWE/CWE-266/IncorrectPrivilegeAssignment.ql

JarLob · web-flow · commit 3fa25168984c · 2022-01-18T21:47:55.000+01:00
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-266/IncorrectPrivilegeAssignment.ql b/cpp/ql/src/experimental/Security/CWE/CWE-266/IncorrectPrivilegeAssignment.ql
@@ -56,7 +56,7 @@ where
     (
       fctmp.getArgument(1).getValue().matches("%a%") or
       fctmp.getArgument(1).getValue().matches("%w%") or
-      // unfortunately cannot use numeric value here because // O_APPEND is defined differently on different OSes:
+      // unfortunately cannot use numeric value here because // O_CREAT is defined differently on different OSes:
       // https://github.com/red/red/blob/92feb0c0d5f91e087ab35fface6906afbf99b603/runtime/definitions.reds#L477-L491
       // this may introduce false negatives
       fctmp.getArgument(1).(BitwiseOrExpr).getAChild*().getValueText().matches("O_CREAT")

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ where`
`56`	`56`	`(`
`57`	`57`	`fctmp.getArgument(1).getValue().matches("%a%") or`
`58`	`58`	`fctmp.getArgument(1).getValue().matches("%w%") or`
`59`		`- // unfortunately cannot use numeric value here because // O_APPEND is defined differently on different OSes:`
	`59`	`+ // unfortunately cannot use numeric value here because // O_CREAT is defined differently on different OSes:`
`60`	`60`	`// https://github.com/red/red/blob/92feb0c0d5f91e087ab35fface6906afbf99b603/runtime/definitions.reds#L477-L491`
`61`	`61`	`// this may introduce false negatives`
`62`	`62`	`fctmp.getArgument(1).(BitwiseOrExpr).getAChild*().getValueText().matches("O_CREAT")`