Skip to content

Commit 41ce4ff

Browse files
committed
C++: Fix some QLDoc holes.
1 parent eca112c commit 41ce4ff

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -375,10 +375,12 @@ private string paramsStringPart(Function c, int i) {
375375
* Parameter types are represented by their type erasure.
376376
*/
377377
cached
378-
string paramsString(Function c) { result = concat(int i | | paramsStringPart(c, i) order by i) }
378+
private string paramsString(Function c) {
379+
result = concat(int i | | paramsStringPart(c, i) order by i)
380+
}
379381

380382
bindingset[func]
381-
predicate matchesSignature(Function func, string signature) {
383+
private predicate matchesSignature(Function func, string signature) {
382384
signature = "" or
383385
paramsString(func) = signature
384386
}

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,6 +1046,10 @@ class DataFlowCallable extends TDataFlowCallable {
10461046
this = TSummarizedCallable(result)
10471047
}
10481048

1049+
/**
1050+
* Gets the underlying `Declaration` of this `DataFlowCallable`. This
1051+
* predicate returns a result for both source and summarized callables.
1052+
*/
10491053
Cpp::Declaration getUnderlyingCallable() {
10501054
result = this.asSummarizedCallable() or // SummarizedCallable = Function (in CPP)
10511055
result = this.asSourceCallable()

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -743,6 +743,10 @@ class InitialGlobalValue extends Node, TInitialGlobalValue {
743743
* of a models-as-data modeled function.
744744
*/
745745
class FlowSummaryNode extends Node, TFlowSummaryNode {
746+
/**
747+
* Gets the models-as-data `SummaryNode` associated with this dataflow
748+
* `FlowSummaryNode`.
749+
*/
746750
FlowSummaryImpl::Private::SummaryNode getSummaryNode() { this = TFlowSummaryNode(result) }
747751

748752
/**

0 commit comments

Comments
 (0)