Skip to content

Commit 45c9a0d

Browse files
aibaarsjketema
andauthored
Apply suggestions from code review
Co-authored-by: Jeroen Ketema <[email protected]>
1 parent 9a0848b commit 45c9a0d

File tree

7 files changed

+7
-9
lines changed

7 files changed

+7
-9
lines changed

go/ql/src/change-notes/released/0.3.2.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22

33
### Minor Analysis Improvements
44

5-
* The alert message of many queries have been changed to better follow the style guide and make the message consistent with other languages.
5+
* The alert messages of many queries were changed to better follow the style guide and make the messages consistent with other languages.

python/ql/src/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* Added model of `cx_Oracle`, `oracledb`, `phonenixdb` and `pyodbc` PyPI packages as a SQL interface following PEP249, resulting in additional sinks for `py/sql-injection`.
66
* Added model of `executemany` calls on PEP-249 compliant database APIs, resulting in additional sinks for `py/sql-injection`.
77
* Added model of `pymssql` PyPI package as a SQL interface following PEP249, resulting in additional sinks for `py/sql-injection`.
8-
* The alert message of many queries have been changed to better follow the style guide and make the message consistent with other languages.
8+
* The alert messages of many queries were changed to better follow the style guide and make the messages consistent with other languages.
99

1010
### Bug Fixes
1111

python/ql/src/change-notes/released/0.5.2.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* Added model of `cx_Oracle`, `oracledb`, `phonenixdb` and `pyodbc` PyPI packages as a SQL interface following PEP249, resulting in additional sinks for `py/sql-injection`.
66
* Added model of `executemany` calls on PEP-249 compliant database APIs, resulting in additional sinks for `py/sql-injection`.
77
* Added model of `pymssql` PyPI package as a SQL interface following PEP249, resulting in additional sinks for `py/sql-injection`.
8-
* The alert message of many queries have been changed to better follow the style guide and make the message consistent with other languages.
8+
* The alert messages of many queries were changed to better follow the style guide and make the messages consistent with other languages.
99

1010
### Bug Fixes
1111

ruby/ql/lib/CHANGELOG.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
### Minor Analysis Improvements
44

55
* The hashing algorithms from `Digest` and `OpenSSL::Digest` are now recognized and can be flagged by the `rb/weak-cryptographic-algorithm` query.
6-
* More sources of remote input arising from methods on `ActionDispatch::Request`
7-
are now recognised.
6+
* More sources of remote input arising from methods on `ActionDispatch::Request` are now recognized.
87
* The response value returned by the `Faraday#run_request` method is now also considered a source of remote input.
98
* `ActiveJob::Serializers.deserialize` is considered to be a code execution sink.
109
* Calls to `params` in `ActionMailer` classes are now treated as sources of remote user input.

ruby/ql/lib/change-notes/released/0.4.2.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
### Minor Analysis Improvements
44

55
* The hashing algorithms from `Digest` and `OpenSSL::Digest` are now recognized and can be flagged by the `rb/weak-cryptographic-algorithm` query.
6-
* More sources of remote input arising from methods on `ActionDispatch::Request`
7-
are now recognised.
6+
* More sources of remote input arising from methods on `ActionDispatch::Request` are now recognized.
87
* The response value returned by the `Faraday#run_request` method is now also considered a source of remote input.
98
* `ActiveJob::Serializers.deserialize` is considered to be a code execution sink.
109
* Calls to `params` in `ActionMailer` classes are now treated as sources of remote user input.

ruby/ql/src/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
* HTTP response header and body writes via `ActionDispatch::Response` are now
1111
recognized.
1212
* The `rb/path-injection` query now treats the `file:` argument of the Rails `render` method as a sink.
13-
* The alert message of many queries have been changed to better follow the style guide and make the message consistent with other languages.
13+
* The alert messages of many queries were changed to better follow the style guide and make the messages consistent with other languages.
1414

1515
## 0.4.1
1616

ruby/ql/src/change-notes/released/0.4.2.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@
1010
* HTTP response header and body writes via `ActionDispatch::Response` are now
1111
recognized.
1212
* The `rb/path-injection` query now treats the `file:` argument of the Rails `render` method as a sink.
13-
* The alert message of many queries have been changed to better follow the style guide and make the message consistent with other languages.
13+
* The alert messages of many queries were changed to better follow the style guide and make the messages consistent with other languages.

0 commit comments

Comments
 (0)