Apply suggestions from code review

Co-authored-by: Owen Mansel-Chan <[email protected]>

Author: egregius313

go/ql/lib/change-notes/2024-08-12-add-environment-models.md

@@ -1,8 +1,8 @@
 ---
 category: minorAnalysis
 ---
-* Local source models for reading and parsing environment variables have been added. The effect libraries include
-  - "os"
+* Local source models for reading and parsing environment variables have been added for the following libraries:
+  - os
   - github.com/hashicorp/go-envparse
   - github.com/joho/godotenv
   - github.com/kelseyhightower/envconfig

go/ql/lib/ext/os.model.yml

@@ -46,9 +46,14 @@ extensions:
       pack: codeql/go-all
       extensible: sourceModel
     data:
-      - ["os", "", False, "Environ", "", "", "ReturnValue", "environment", "manual"]
+      - ["os", "", False, "Environ", "", "", "ReturnValue", "environment", "manual"] # TODO: when sources can have access paths, use .ArrayElement
+      - ["os", "", False, "ExpandEnv", "", "", "ReturnValue", "environment", "manual"]
       - ["os", "", False, "Getenv", "", "", "ReturnValue", "environment", "manual"]
       - ["os", "", False, "LookupEnv", "", "", "ReturnValue[0]", "environment", "manual"]
       - ["os", "", False, "Open", "", "", "ReturnValue[0]", "file", "manual"]
       - ["os", "", False, "OpenFile", "", "", "ReturnValue[0]", "file", "manual"]
       - ["os", "", False, "ReadFile", "", "", "ReturnValue[0]", "file", "manual"]
+      - ["os", "", False, "UserCacheDir", "", "", "ReturnValue[0]", "environment", "manual"]
+      - ["os", "", False, "UserConfigDir", "", "", "ReturnValue[0]", "environment", "manual"]
+      - ["os", "", False, "UserHomeDir", "", "", "ReturnValue[0]", "environment", "manual"]
+      - ["os", "ProcAttr", False, "Env", "", "", "", "environment", "manual"] # TODO: when sources can have access paths, use .ArrayElement