JS: Fix incorrect fix.

MathiasVP · MathiasVP · commit 4991301f3650 · 2021-10-13T19:45:02.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/security/UselessUseOfCat.qll b/javascript/ql/lib/semmle/javascript/security/UselessUseOfCat.qll
@@ -307,7 +307,7 @@ module PrettyPrintCatCall {
     then result = str.suffix(5)
     else
       // prettify `${newpath}` to just newpath
-      if str.matches("`${%") and str.matches("}`%") and not str.suffix(3).matches("%{%")
+      if str.matches("`${%") and str.matches("%}`") and not str.suffix(3).matches("%{%")
       then result = str.prefix(str.length() - 2).suffix(3)
       else result = str
   }

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ module PrettyPrintCatCall {`
`307`	`307`	`then result = str.suffix(5)`
`308`	`308`	`else`
`309`	`309`	// prettify `${newpath}` to just newpath
`310`		- if str.matches("`${%") and str.matches("}`%") and not str.suffix(3).matches("%{%")
	`310`	+ if str.matches("`${%") and str.matches("%}`") and not str.suffix(3).matches("%{%")
`311`	`311`	`then result = str.prefix(str.length() - 2).suffix(3)`
`312`	`312`	`else result = str`
`313`	`313`	`}`