Skip to content

Commit 4bc3e9e

Browse files
Napalysasgerf
andcommitted
Addressed comments
Co-authored-by: Asgerf <[email protected]>
1 parent 873db7c commit 4bc3e9e

File tree

2 files changed

+8
-17
lines changed

2 files changed

+8
-17
lines changed

javascript/ql/lib/semmle/javascript/internal/flow_summaries/Decoders.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ class DecodeLike extends SummarizedCallable {
1717
DecodeLike() { this = "TextDecoder#decode" }
1818

1919
override InstanceCall getACall() {
20-
result =
21-
textDecoderConstructorRef().getAnInstantiation().getReturn().getMember("decode").getACall()
20+
result = textDecoderConstructorRef().getInstance().getMember("decode").getACall()
2221
}
2322

2423
override predicate propagatesFlow(string input, string output, boolean preservesValue) {

javascript/ql/lib/semmle/javascript/internal/flow_summaries/TypedArrays.qll

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ class BufferTypedArray extends DataFlow::AdditionalFlowStep {
3737
}
3838
}
3939

40-
class SetLike extends SummarizedCallable {
41-
SetLike() { this = "TypedArray#set" }
40+
class TypedArraySet extends SummarizedCallable {
41+
TypedArraySet() { this = "TypedArray#set" }
4242

4343
override InstanceCall getACall() {
44-
result = typedArrayConstructorRef().getAnInstantiation().getReturn().getMember("set").getACall()
44+
result = typedArrayConstructorRef().getInstance().getMember("set").getACall()
4545
}
4646

4747
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
@@ -51,13 +51,10 @@ class SetLike extends SummarizedCallable {
5151
}
5252
}
5353

54-
class SubArrayLike extends SummarizedCallable {
55-
SubArrayLike() { this = "TypedArray#subarray" }
54+
class TypedArraySubarray extends SummarizedCallable {
55+
TypedArraySubarray() { this = "TypedArray#subarray" }
5656

57-
override InstanceCall getACall() {
58-
result =
59-
typedArrayConstructorRef().getAnInstantiation().getReturn().getMember("subarray").getACall()
60-
}
57+
override InstanceCall getACall() { result.getMethodName() = "subarray" }
6158

6259
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
6360
preservesValue = true and
@@ -95,12 +92,7 @@ class TransferLike extends SummarizedCallable {
9592
TransferLike() { this = "ArrayBuffer#transfer" }
9693

9794
override InstanceCall getACall() {
98-
result =
99-
arrayBufferConstructorRef()
100-
.getAnInstantiation()
101-
.getReturn()
102-
.getMember(["transfer", "transferToFixedLength"])
103-
.getACall()
95+
result.getMethodName() = ["transfer", "transferToFixedLength"]
10496
}
10597

10698
override predicate propagatesFlow(string input, string output, boolean preservesValue) {

0 commit comments

Comments
 (0)