Merge pull request #14564 from michaelnebel/csharp/cildefaultfalse

C#: Disable CIL extraction by default.

Author: michaelnebel

csharp/extractor/Semmle.Extraction.Tests/Options.cs

@@ -22,7 +22,7 @@ public void DefaultOptions()
         {
             options = CSharp.Options.CreateWithEnvironment(Array.Empty<string>());
             Assert.True(options.Cache);
-            Assert.True(options.CIL);
+            Assert.False(options.CIL);
             Assert.Null(options.Framework);
             Assert.Null(options.CompilerName);
             Assert.Empty(options.CompilerArguments);
@@ -52,7 +52,7 @@ public void Cache()
         public void CIL()
         {
             options = CSharp.Options.CreateWithEnvironment(Array.Empty<string>());
-            Assert.True(options.CIL);
+            Assert.False(options.CIL);
 
             Environment.SetEnvironmentVariable("CODEQL_EXTRACTOR_CSHARP_OPTION_CIL", "false");
             options = CSharp.Options.CreateWithEnvironment(Array.Empty<string>());
@@ -64,7 +64,7 @@ public void CIL()
 
             Environment.SetEnvironmentVariable("CODEQL_EXTRACTOR_CSHARP_OPTION_CIL", null);
             options = CSharp.Options.CreateWithEnvironment(Array.Empty<string>());
-            Assert.True(options.CIL);
+            Assert.False(options.CIL);
         }
 
         [Fact]

csharp/extractor/Semmle.Extraction/Options.cs

@@ -28,7 +28,7 @@ public abstract class CommonOptions : ICommandLineOptions
         /// <summary>
         /// Holds if CIL should be extracted.
         /// </summary>
-        public bool CIL { get; private set; } = true;
+        public bool CIL { get; private set; } = false;
 
         /// <summary>
         /// Holds if assemblies shouldn't be extracted twice.

csharp/ql/src/change-notes/2023-10-24-disable-cil.md

@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* CIL extraction is now disabled by default. It is still possible to turn on CIL extraction by setting the `cil` extractor option to `true` or by setting the environment variable `$CODEQL_EXTRACTOR_CSHARP_OPTION_CIL` to `true`. This is the first step towards sun-setting the CIL extractor entirely.