Skip to content

Commit 4dd9e7d

Browse files
committed
Remove unnecessary import
Add comment
1 parent 1496310 commit 4dd9e7d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

java/ql/lib/semmle/code/java/security/AndroidIntentRedirectionQuery.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,10 @@ private class TaintedIntentComponentConf extends TaintTracking2::Configuration {
7070

7171
/** Holds if `expr` modifies the component of an `Intent`. */
7272
private predicate changesIntentComponent(Expr expr) {
73-
any(IntentGetParcelableExtra igpe) = expr or
7473
any(IntentSetComponent isc).getSink() = expr
74+
or
75+
// obtaining an arbitrary Intent as a Parcelable extra
76+
expr instanceof IntentGetParcelableExtra
7577
}
7678

7779
/** A call to the method `Intent.getParcelableExtra`. */

java/ql/src/Security/CWE/CWE-940/AndroidIntentRedirection.ql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
*/
1515

1616
import java
17-
import semmle.code.java.dataflow.DataFlow
1817
import semmle.code.java.security.AndroidIntentRedirectionQuery
1918
import DataFlow::PathGraph
2019

0 commit comments

Comments
 (0)