Optimize concatAndCompareAgainstFullHostRegex

jorgectf · jorgectf · commit 4e261c61aed0 · 2021-09-07T19:05:03.000+02:00
diff --git a/python/ql/src/experimental/semmle/python/security/LDAPInsecureAuth.qll b/python/ql/src/experimental/semmle/python/security/LDAPInsecureAuth.qll
@@ -38,12 +38,8 @@ class LDAPPrivateHost extends StrConst {
 }
 
 predicate concatAndCompareAgainstFullHostRegex(LDAPSchema schema, StrConst host) {
-  schema instanceof LDAPSchema and
   not host instanceof LDAPPrivateHost and
-  exists(string full_host |
-    full_host = schema.(StrConst).getText() + host.(StrConst).getText() and
-    full_host.regexpMatch(getFullHostRegex())
-  )
+  (schema.getText() + host.getText()).regexpMatch(getFullHostRegex())
 }
 
 // "ldap://" + "somethingon.theinternet.com"

Original file line number	Diff line number	Diff line change
`@@ -38,12 +38,8 @@ class LDAPPrivateHost extends StrConst {`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`predicate concatAndCompareAgainstFullHostRegex(LDAPSchema schema, StrConst host) {`
`41`		`- schema instanceof LDAPSchema and`
`42`	`41`	`not host instanceof LDAPPrivateHost and`
`43`		`- exists(string full_host \|`
`44`		`- full_host = schema.(StrConst).getText() + host.(StrConst).getText() and`
`45`		`- full_host.regexpMatch(getFullHostRegex())`
`46`		`- )`
	`42`	`+ (schema.getText() + host.getText()).regexpMatch(getFullHostRegex())`
`47`	`43`	`}`
`48`	`44`
`49`	`45`	`// "ldap://" + "somethingon.theinternet.com"`