Merge pull request #7566 from MathiasVP/smaller-join-in-reachesRefParameter

rdmarsh2 · web-flow · commit 5031d6c4a376 · 2022-01-12T10:04:35.000-05:00
C++: Smaller join in `reachesRefParameter`
diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowVar.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowVar.qll
@@ -435,7 +435,7 @@ module FlowVar_internal {
       parameterIsNonConstReference(p) and
       p = v and
       // This definition reaches the exit node of the function CFG
-      getAReachedBlockVarSBB(this).getANode() = p.getFunction()
+      getAReachedBlockVarSBB(this).getEnd() = p.getFunction()
     }
 
     override predicate definedByInitialValue(StackVariable lsv) {

Original file line number	Diff line number	Diff line change
`@@ -435,7 +435,7 @@ module FlowVar_internal {`
`435`	`435`	`parameterIsNonConstReference(p) and`
`436`	`436`	`p = v and`
`437`	`437`	`// This definition reaches the exit node of the function CFG`
`438`		`- getAReachedBlockVarSBB(this).getANode() = p.getFunction()`
	`438`	`+ getAReachedBlockVarSBB(this).getEnd() = p.getFunction()`
`439`	`439`	`}`
`440`	`440`
`441`	`441`	`override predicate definedByInitialValue(StackVariable lsv) {`