Skip to content

Commit 5073f4f

Browse files
authored
Merge pull request #17096 from aschackmull/java/pp-experimental-models
Java: Pretty-print experimental models for qltest.
2 parents 1347f55 + da5250d commit 5073f4f

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ abstract class ActiveExperimentalModels extends string {
124124
*/
125125
predicate sinkModel(
126126
string package, string type, boolean subtypes, string name, string signature, string ext,
127-
string output, string kind, string provenance, QlBuiltins::ExtensionId madId
127+
string input, string kind, string provenance, QlBuiltins::ExtensionId madId
128128
) {
129-
Extensions::experimentalSinkModel(package, type, subtypes, name, signature, ext, output, kind,
129+
Extensions::experimentalSinkModel(package, type, subtypes, name, signature, ext, input, kind,
130130
provenance, this, madId)
131131
}
132132

@@ -195,7 +195,10 @@ predicate interpretModelForTest(QlBuiltins::ExtensionId madId, string model) {
195195
string package, string type, boolean subtypes, string name, string signature, string ext,
196196
string output, string kind, string provenance
197197
|
198-
sourceModel(package, type, subtypes, name, signature, ext, output, kind, provenance, madId) and
198+
sourceModel(package, type, subtypes, name, signature, ext, output, kind, provenance, madId) or
199+
Extensions::experimentalSourceModel(package, type, subtypes, name, signature, ext, output, kind,
200+
provenance, _, madId)
201+
|
199202
model =
200203
"Source: " + package + "; " + type + "; " + subtypes + "; " + name + "; " + signature + "; " +
201204
ext + "; " + output + "; " + kind + "; " + provenance
@@ -205,7 +208,10 @@ predicate interpretModelForTest(QlBuiltins::ExtensionId madId, string model) {
205208
string package, string type, boolean subtypes, string name, string signature, string ext,
206209
string input, string kind, string provenance
207210
|
208-
sinkModel(package, type, subtypes, name, signature, ext, input, kind, provenance, madId) and
211+
sinkModel(package, type, subtypes, name, signature, ext, input, kind, provenance, madId) or
212+
Extensions::experimentalSinkModel(package, type, subtypes, name, signature, ext, input, kind,
213+
provenance, _, madId)
214+
|
209215
model =
210216
"Sink: " + package + "; " + type + "; " + subtypes + "; " + name + "; " + signature + "; " +
211217
ext + "; " + input + "; " + kind + "; " + provenance
@@ -216,7 +222,10 @@ predicate interpretModelForTest(QlBuiltins::ExtensionId madId, string model) {
216222
string input, string output, string kind, string provenance
217223
|
218224
summaryModel(package, type, subtypes, name, signature, ext, input, output, kind, provenance,
219-
madId) and
225+
madId) or
226+
Extensions::experimentalSummaryModel(package, type, subtypes, name, signature, ext, input,
227+
output, kind, provenance, _, madId)
228+
|
220229
model =
221230
"Summary: " + package + "; " + type + "; " + subtypes + "; " + name + "; " + signature + "; " +
222231
ext + "; " + input + "; " + output + "; " + kind + "; " + provenance

0 commit comments

Comments
 (0)