Skip to content

Commit 5112eb3

Browse files
committed
JS: EnvValueAndKeyInjection
1 parent 9fc93e0 commit 5112eb3

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

javascript/ql/src/experimental/Security/CWE-099/EnvValueAndKeyInjection.ql

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,7 @@ module EnvValueAndKeyInjectionConfig implements DataFlow::ConfigSig {
3535
}
3636

3737
predicate observeDiffInformedIncrementalMode() {
38-
any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 66 (/Users/d10c/src/semmle-code/ql/javascript/ql/src/experimental/Security/CWE-099/EnvValueAndKeyInjection.ql@69:8:69:23)
39-
}
40-
41-
Location getASelectedSinkLocation(DataFlow::Node sink) {
42-
none() // TODO: Make sure that this sink location matches the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 66 (/Users/d10c/src/semmle-code/ql/javascript/ql/src/experimental/Security/CWE-099/EnvValueAndKeyInjection.ql@69:8:69:23)
38+
none() // can't override location accurately because of secondary use in select.
4339
}
4440
}
4541

0 commit comments

Comments
 (0)