Skip to content

Commit 5228196

Browse files
committed
fix typos and update docs
1 parent 311df4d commit 5228196

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

javascript/ql/lib/semmle/javascript/frameworks/CookieLibraries.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,11 @@ module CookieWrites {
2424

2525
/**
2626
* Holds if the cookie is likely an authentication cookie or otherwise sensitive.
27-
* Can never hold for client-side cookies.
2827
*/
2928
abstract predicate isSensitive();
3029

3130
/**
32-
* Holds if the cookie write happens on a server, that is `httpOnly` flag is relevant.
31+
* Holds if the cookie write happens on a server, i.e. the `httpOnly` flag is relevant.
3332
*/
3433
predicate isServerSide() {
3534
any() // holds by default. Client-side cookie writes should extend ClientSideCookieWrite.

javascript/ql/src/Security/CWE-1004/ClientExposedCookie.qhelp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<overview>
77
<p>
88
Authentication cookies stored by a server can be accessed by a client if the <code>httpOnly</code> flag is not set.
9-
<p>
9+
</p>
1010
<p>
1111
An attacker that manages a cross-site scripting (XSS) attack can read the cookie and hijack the session.
1212
</p>
@@ -18,8 +18,6 @@ Set the <code>httpOnly</code> flag on all cookies that are not needed by the cli
1818
</p>
1919
</recommendation>
2020

21-
<references>
22-
2321
<example>
2422
<p>
2523
The following example stores an authentication token in a cookie that can

javascript/ql/src/Security/CWE-614/ClearTextCookie.qhelp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ attribute on the cookie.
2222
The following example stores an authentication token in a cookie that can
2323
be transmitted in clear text.
2424
</p>
25-
<sample src="examples/CleartextStorageBad.js"/>
25+
<sample src="examples/ClearTextCookieBad.js"/>
2626
<p>
2727
To force the cookie to be transmitted using SSL, set the <code>secure</code>
2828
attribute on the cookie.
2929
</p>
30-
<sample src="examples/CleartextStorageGood.js"/>
30+
<sample src="examples/ClearTextCookieGood.js"/>
3131
</example>
3232

3333
<references>

0 commit comments

Comments
 (0)