Skip to content

Commit 5297121

Browse files
committed
C++: Address review comments
1 parent a08d594 commit 5297121

File tree

1 file changed

+3
-6
lines changed
  • cpp/ql/lib/semmle/code/cpp/ir/implementation

1 file changed

+3
-6
lines changed

cpp/ql/lib/semmle/code/cpp/ir/implementation/Opcode.qll

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ private newtype TOpcode =
9393
TInlineAsm() or
9494
TUnreached() or
9595
TNewObj() or
96-
TTypeid() or
9796
TTypeidExpr() or
9897
TTypeidType()
9998

@@ -1290,16 +1289,14 @@ module Opcode {
12901289
*
12911290
* See the `TypeidInstruction` documentation for more details.
12921291
*/
1293-
class Typeid extends Opcode, TTypeid {
1294-
final override string toString() { result = "Typeid" }
1295-
}
1292+
abstract class Typeid extends Opcode { }
12961293

12971294
/**
12981295
* The `Opcode` for a `TypeidExprInstruction`.
12991296
*
13001297
* See the `TypeidExprInstruction` documentation for more details.
13011298
*/
1302-
class TypeidExpr extends UnaryOpcode, TTypeidExpr {
1299+
class TypeidExpr extends Typeid, UnaryOpcode, TTypeidExpr {
13031300
final override string toString() { result = "TypeidExpr" }
13041301
}
13051302

@@ -1308,7 +1305,7 @@ module Opcode {
13081305
*
13091306
* See the `TypeidTypeInstruction` documentation for more details.
13101307
*/
1311-
class TypeidType extends Opcode, TTypeidType {
1308+
class TypeidType extends Typeid, TTypeidType {
13121309
final override string toString() { result = "TypeidType" }
13131310
}
13141311
}

0 commit comments

Comments
 (0)