Skip to content

Commit 52ca6b9

Browse files
Make things private where possible
1 parent 351e67c commit 52ca6b9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

java/ql/src/semmle/code/java/security/AndroidSensitiveBroadcastQuery.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import semmle.code.java.security.SensitiveActions
1212
private string getAndroidSensitiveInfoRegex() { result = "(?i).*(email|phone|ticket).*" }
1313

1414
/** Finds variables that hold sensitive information judging by their names. */
15-
class SensitiveInfoExpr extends Expr {
15+
private class SensitiveInfoExpr extends Expr {
1616
SensitiveInfoExpr() {
1717
exists(Variable v | this = v.getAnAccess() |
1818
v.getName().regexpMatch([getCommonSensitiveInfoRegex(), getAndroidSensitiveInfoRegex()])
@@ -23,7 +23,7 @@ class SensitiveInfoExpr extends Expr {
2323
/**
2424
* A method access of the `Context.sendBroadcast` family.
2525
*/
26-
class SendBroadcastMethodAccess extends MethodAccess {
26+
private class SendBroadcastMethodAccess extends MethodAccess {
2727
SendBroadcastMethodAccess() {
2828
this.getMethod().getDeclaringType().getASourceSupertype*() instanceof TypeContext and
2929
this.getMethod().getName().matches("send%Broadcast%")
@@ -53,7 +53,7 @@ private predicate isEmptyArrayArg(Expr ex) {
5353
/**
5454
* Holds if a `sendBroadcast` call doesn't specify receiver permission.
5555
*/
56-
predicate isSensitiveBroadcastSink(DataFlow::Node sink) {
56+
private predicate isSensitiveBroadcastSink(DataFlow::Node sink) {
5757
exists(SendBroadcastMethodAccess ma, string name | ma.getMethod().hasName(name) |
5858
sink.asExpr() = ma.getAnArgument() and
5959
(

0 commit comments

Comments
 (0)