Skip to content

Commit 55fdf84

Browse files
committed
Ruby+JS: change LabelEntryPoint.toString()
fixup Ruby entry point tests
1 parent c9ba6f1 commit 55fdf84

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

javascript/ql/lib/semmle/javascript/ApiGraphs.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1495,7 +1495,7 @@ module API {
14951495
/** Gets the EntryPoint associated with this label. */
14961496
API::EntryPoint getEntryPoint() { result = e }
14971497

1498-
override string toString() { result = "getASuccessor(Label::entryPoint(\"" + e + "\"))" }
1498+
override string toString() { result = "entryPoint(\"" + e + "\")" }
14991499
}
15001500

15011501
/** A label that gets a promised value. */
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
module.exports = CustomEntryPoint.foo; /* use=getASuccessor(Label::entryPoint("CustomEntryPoint")) */
1+
module.exports = CustomEntryPoint.foo; /* use=entryPoint("CustomEntryPoint") */

javascript/ql/test/library-tests/frameworks/Redux/test.expected

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ getAffectedStateAccessPath
125125
getADispatchFunctionNode
126126
| react-redux.jsx:65:20:65:32 | use moduleImport("react-redux").getMember("exports").getMember("useDispatch").getReturn() |
127127
getADispatchedValueNode
128-
| react-redux.jsx:27:12:30:5 | def getASuccessor(Label::entryPoint("react-redux-connect")).getParameter(1).getMember("manualAction").getReturn() |
128+
| react-redux.jsx:27:12:30:5 | def entryPoint("react-redux-connect").getParameter(1).getMember("manualAction").getReturn() |
129129
| react-redux.jsx:69:18:69:39 | def moduleImport("react-redux").getMember("exports").getMember("useDispatch").getReturn().getParameter(0) |
130130
| react-redux.jsx:70:18:70:38 | def moduleImport("react-redux").getMember("exports").getMember("useDispatch").getReturn().getParameter(0) |
131131
getAnUntypedActionInReducer

ruby/ql/lib/codeql/ruby/ApiGraphs.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -838,7 +838,7 @@ module API {
838838

839839
LabelEntryPoint() { this = MkLabelEntryPoint(name) }
840840

841-
override string toString() { result = name }
841+
override string toString() { result = "entryPoint(\"" + name + "\")" }
842842

843843
/** Gets the name of the entry point. */
844844
API::EntryPoint getName() { result = name }

ruby/ql/test/library-tests/dataflow/api-graphs/test1.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class C2 < M1::C1 #$ use=getMember("M1").getMember("C1")
4646
module M2
4747
class C3 < M1::C1 #$ use=getMember("M1").getMember("C1")
4848
end
49-
49+
5050
class C4 < C2 #$ use=getMember("C2")
5151
end
5252
end
@@ -65,6 +65,6 @@ class C4 < C2 #$ use=getMember("C2")
6565

6666
def userDefinedFunction(x, y)
6767
x.noApiGraph(y)
68-
x.customEntryPointCall(y) #$ call=CustomEntryPointCall use=CustomEntryPointCall.getReturn() rhs=CustomEntryPointCall.getParameter(0)
69-
x.customEntryPointUse(y) #$ use=CustomEntryPointUse
68+
x.customEntryPointCall(y) #$ call=entryPoint("CustomEntryPointCall") use=entryPoint("CustomEntryPointCall").getReturn() rhs=entryPoint("CustomEntryPointCall").getParameter(0)
69+
x.customEntryPointUse(y) #$ use=entryPoint("CustomEntryPointUse")
7070
end

0 commit comments

Comments
 (0)