Python: remove spurious dataflow step

yoff · yoff · commit 56dab252c9f6 · 2021-10-28T09:47:04.000+02:00
diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll
@@ -171,6 +171,7 @@ module EssaFlow {
       // see `with_flow` in `python/ql/src/semmle/python/dataflow/Implementation.qll`
       with.getContextExpr() = contextManager.getNode() and
       with.getOptionalVars() = var.getNode() and
+      not with.isAsync() and
       contextManager.strictlyDominates(var)
     )
     or

Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,7 @@ module EssaFlow {`
`171`	`171`	// see `with_flow` in `python/ql/src/semmle/python/dataflow/Implementation.qll`
`172`	`172`	`with.getContextExpr() = contextManager.getNode() and`
`173`	`173`	`with.getOptionalVars() = var.getNode() and`
	`174`	`+ not with.isAsync() and`
`174`	`175`	`contextManager.strictlyDominates(var)`
`175`	`176`	`)`
`176`	`177`	`or`