Skip to content

Commit 57ff30c

Browse files
committed
Update tests: built-in models now work
1 parent 1ccea88 commit 57ff30c

File tree

3 files changed

+22
-0
lines changed

3 files changed

+22
-0
lines changed

go/ql/test/library-tests/semmle/go/dataflow/FlowSteps/LocalFlowStep.expected

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
| file://:0:0:0:0 | [summary param] 1 in append | file://:0:0:0:0 | [summary] to write: ReturnValue.ArrayElement in append |
2+
| file://:0:0:0:0 | [summary] read: Argument[0].ArrayElement in append | file://:0:0:0:0 | [summary] to write: ReturnValue.ArrayElement in append |
13
| file://:0:0:0:0 | function Encode | url.go:51:14:51:21 | selection of Encode |
24
| file://:0:0:0:0 | function EscapedPath | url.go:28:14:28:26 | selection of EscapedPath |
35
| file://:0:0:0:0 | function Get | url.go:52:14:52:18 | selection of Get |

go/ql/test/library-tests/semmle/go/dataflow/PromotedFields/LocalFlowStep.expected

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
| file://:0:0:0:0 | [summary param] 1 in append | file://:0:0:0:0 | [summary] to write: ReturnValue.ArrayElement in append |
2+
| file://:0:0:0:0 | [summary] read: Argument[0].ArrayElement in append | file://:0:0:0:0 | [summary] to write: ReturnValue.ArrayElement in append |
13
| main.go:3:6:3:11 | function source | main.go:23:31:23:36 | source |
24
| main.go:3:6:3:11 | function source | main.go:31:31:31:36 | source |
35
| main.go:3:6:3:11 | function source | main.go:40:30:40:35 | source |

go/ql/test/query-tests/Security/CWE-078/CommandInjection.expected

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ edges
1313
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:13:25:13:31 | tainted | provenance | |
1414
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:14:23:14:33 | slice expression | provenance | |
1515
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:39:31:39:37 | tainted | provenance | |
16+
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:52:24:52:30 | tainted | provenance | |
1617
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:53:21:53:28 | arrayLit | provenance | |
1718
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:68:31:68:37 | tainted | provenance | |
1819
| SanitizingDoubleDash.go:9:13:9:27 | call to Query | SanitizingDoubleDash.go:80:23:80:29 | tainted | provenance | |
@@ -23,8 +24,12 @@ edges
2324
| SanitizingDoubleDash.go:14:23:14:33 | slice expression [array] | SanitizingDoubleDash.go:14:23:14:33 | slice expression | provenance | |
2425
| SanitizingDoubleDash.go:39:14:39:44 | call to append | SanitizingDoubleDash.go:40:23:40:30 | arrayLit | provenance | |
2526
| SanitizingDoubleDash.go:39:31:39:37 | tainted | SanitizingDoubleDash.go:39:14:39:44 | call to append | provenance | FunctionModel |
27+
| SanitizingDoubleDash.go:52:15:52:31 | slice literal [array] | SanitizingDoubleDash.go:53:21:53:28 | arrayLit [array] | provenance | |
28+
| SanitizingDoubleDash.go:52:24:52:30 | tainted | SanitizingDoubleDash.go:52:15:52:31 | slice literal [array] | provenance | |
2629
| SanitizingDoubleDash.go:53:14:53:35 | call to append | SanitizingDoubleDash.go:54:23:54:30 | arrayLit | provenance | |
30+
| SanitizingDoubleDash.go:53:14:53:35 | call to append [array] | SanitizingDoubleDash.go:54:23:54:30 | arrayLit | provenance | |
2731
| SanitizingDoubleDash.go:53:21:53:28 | arrayLit | SanitizingDoubleDash.go:53:14:53:35 | call to append | provenance | FunctionModel |
32+
| SanitizingDoubleDash.go:53:21:53:28 | arrayLit [array] | SanitizingDoubleDash.go:53:14:53:35 | call to append [array] | provenance | MaD:28 |
2833
| SanitizingDoubleDash.go:68:14:68:38 | call to append | SanitizingDoubleDash.go:69:21:69:28 | arrayLit | provenance | |
2934
| SanitizingDoubleDash.go:68:31:68:37 | tainted | SanitizingDoubleDash.go:68:14:68:38 | call to append | provenance | FunctionModel |
3035
| SanitizingDoubleDash.go:69:14:69:35 | call to append | SanitizingDoubleDash.go:70:23:70:30 | arrayLit | provenance | |
@@ -39,6 +44,7 @@ edges
3944
| SanitizingDoubleDash.go:92:13:92:27 | call to Query | SanitizingDoubleDash.go:111:37:111:43 | tainted | provenance | |
4045
| SanitizingDoubleDash.go:92:13:92:27 | call to Query | SanitizingDoubleDash.go:117:31:117:37 | tainted | provenance | |
4146
| SanitizingDoubleDash.go:92:13:92:27 | call to Query | SanitizingDoubleDash.go:123:31:123:37 | tainted | provenance | |
47+
| SanitizingDoubleDash.go:92:13:92:27 | call to Query | SanitizingDoubleDash.go:128:24:128:30 | tainted | provenance | |
4248
| SanitizingDoubleDash.go:92:13:92:27 | call to Query | SanitizingDoubleDash.go:129:21:129:28 | arrayLit | provenance | |
4349
| SanitizingDoubleDash.go:92:13:92:27 | call to Query | SanitizingDoubleDash.go:136:31:136:37 | tainted | provenance | |
4450
| SanitizingDoubleDash.go:92:13:92:27 | call to Query | SanitizingDoubleDash.go:142:31:142:37 | tainted | provenance | |
@@ -62,8 +68,12 @@ edges
6268
| SanitizingDoubleDash.go:117:31:117:37 | tainted | SanitizingDoubleDash.go:117:14:117:44 | call to append | provenance | FunctionModel |
6369
| SanitizingDoubleDash.go:123:14:123:38 | call to append | SanitizingDoubleDash.go:124:24:124:31 | arrayLit | provenance | |
6470
| SanitizingDoubleDash.go:123:31:123:37 | tainted | SanitizingDoubleDash.go:123:14:123:38 | call to append | provenance | FunctionModel |
71+
| SanitizingDoubleDash.go:128:15:128:31 | slice literal [array] | SanitizingDoubleDash.go:129:21:129:28 | arrayLit [array] | provenance | |
72+
| SanitizingDoubleDash.go:128:24:128:30 | tainted | SanitizingDoubleDash.go:128:15:128:31 | slice literal [array] | provenance | |
6573
| SanitizingDoubleDash.go:129:14:129:35 | call to append | SanitizingDoubleDash.go:130:24:130:31 | arrayLit | provenance | |
74+
| SanitizingDoubleDash.go:129:14:129:35 | call to append [array] | SanitizingDoubleDash.go:130:24:130:31 | arrayLit | provenance | |
6675
| SanitizingDoubleDash.go:129:21:129:28 | arrayLit | SanitizingDoubleDash.go:129:14:129:35 | call to append | provenance | FunctionModel |
76+
| SanitizingDoubleDash.go:129:21:129:28 | arrayLit [array] | SanitizingDoubleDash.go:129:14:129:35 | call to append [array] | provenance | MaD:28 |
6777
| SanitizingDoubleDash.go:136:14:136:38 | call to append | SanitizingDoubleDash.go:137:24:137:31 | arrayLit | provenance | |
6878
| SanitizingDoubleDash.go:136:31:136:37 | tainted | SanitizingDoubleDash.go:136:14:136:38 | call to append | provenance | FunctionModel |
6979
| SanitizingDoubleDash.go:142:14:142:38 | call to append | SanitizingDoubleDash.go:143:21:143:28 | arrayLit | provenance | |
@@ -95,8 +105,12 @@ nodes
95105
| SanitizingDoubleDash.go:39:14:39:44 | call to append | semmle.label | call to append |
96106
| SanitizingDoubleDash.go:39:31:39:37 | tainted | semmle.label | tainted |
97107
| SanitizingDoubleDash.go:40:23:40:30 | arrayLit | semmle.label | arrayLit |
108+
| SanitizingDoubleDash.go:52:15:52:31 | slice literal [array] | semmle.label | slice literal [array] |
109+
| SanitizingDoubleDash.go:52:24:52:30 | tainted | semmle.label | tainted |
98110
| SanitizingDoubleDash.go:53:14:53:35 | call to append | semmle.label | call to append |
111+
| SanitizingDoubleDash.go:53:14:53:35 | call to append [array] | semmle.label | call to append [array] |
99112
| SanitizingDoubleDash.go:53:21:53:28 | arrayLit | semmle.label | arrayLit |
113+
| SanitizingDoubleDash.go:53:21:53:28 | arrayLit [array] | semmle.label | arrayLit [array] |
100114
| SanitizingDoubleDash.go:54:23:54:30 | arrayLit | semmle.label | arrayLit |
101115
| SanitizingDoubleDash.go:68:14:68:38 | call to append | semmle.label | call to append |
102116
| SanitizingDoubleDash.go:68:31:68:37 | tainted | semmle.label | tainted |
@@ -130,8 +144,12 @@ nodes
130144
| SanitizingDoubleDash.go:123:14:123:38 | call to append | semmle.label | call to append |
131145
| SanitizingDoubleDash.go:123:31:123:37 | tainted | semmle.label | tainted |
132146
| SanitizingDoubleDash.go:124:24:124:31 | arrayLit | semmle.label | arrayLit |
147+
| SanitizingDoubleDash.go:128:15:128:31 | slice literal [array] | semmle.label | slice literal [array] |
148+
| SanitizingDoubleDash.go:128:24:128:30 | tainted | semmle.label | tainted |
133149
| SanitizingDoubleDash.go:129:14:129:35 | call to append | semmle.label | call to append |
150+
| SanitizingDoubleDash.go:129:14:129:35 | call to append [array] | semmle.label | call to append [array] |
134151
| SanitizingDoubleDash.go:129:21:129:28 | arrayLit | semmle.label | arrayLit |
152+
| SanitizingDoubleDash.go:129:21:129:28 | arrayLit [array] | semmle.label | arrayLit [array] |
135153
| SanitizingDoubleDash.go:130:24:130:31 | arrayLit | semmle.label | arrayLit |
136154
| SanitizingDoubleDash.go:136:14:136:38 | call to append | semmle.label | call to append |
137155
| SanitizingDoubleDash.go:136:31:136:37 | tainted | semmle.label | tainted |

0 commit comments

Comments
 (0)