Skip to content

Commit 59147ad

Browse files
committed
QL: Add more tests for MissingOverride.ql
1 parent 5259a6e commit 59147ad

File tree

2 files changed

+27
-0
lines changed

2 files changed

+27
-0
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,4 @@
11
| Test.qll:12:13:12:16 | ClassPredicate test | Wrong.test overrides $@ but does not have an override annotation. | Test.qll:4:13:4:16 | ClassPredicate test | Super.test |
2+
| Test.qll:18:13:18:16 | ClassPredicate test | Wrong2.test overrides $@ but does not have an override annotation. | Test.qll:4:13:4:16 | ClassPredicate test | Super.test |
3+
| Test.qll:24:13:24:16 | ClassPredicate test | Correct2.test overrides $@ but does not have an override annotation. | Test.qll:4:13:4:16 | ClassPredicate test | Super.test |
4+
| Test.qll:36:13:36:16 | ClassPredicate test | Correct4.test overrides $@ but does not have an override annotation. | Test.qll:32:13:32:16 | ClassPredicate test | Super2.test |

ql/ql/test/queries/style/MissingOverride/Test.qll

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,27 @@ class Correct extends Super {
1111
class Wrong extends Super {
1212
predicate test(int i) { i = 2 }
1313
}
14+
15+
class Mid extends Super { }
16+
17+
class Wrong2 extends Mid {
18+
predicate test(int i) { i = 2 }
19+
}
20+
21+
final class SuperFinal = Super;
22+
23+
class Correct2 extends SuperFinal {
24+
predicate test(int i) { i = 4 }
25+
}
26+
27+
class Correct3 extends AstNode instanceof SuperFinal {
28+
predicate test(int i) { i = 4 }
29+
}
30+
31+
final class Super2 extends AstNode {
32+
predicate test(int i) { i = [1 .. 5] }
33+
}
34+
35+
class Correct4 extends Super2 {
36+
predicate test(int i) { i = 3 }
37+
}

0 commit comments

Comments
 (0)