Skip to content

Commit 5b38ba8

Browse files
committed
Code quality improvement
1 parent b455b2c commit 5b38ba8

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

csharp/autobuilder/Semmle.Autobuild.Shared/BuildActions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ bool IBuildActions.IsRunningOnAppleSilicon()
252252

253253
try
254254
{
255-
var res = thisBuildActions.RunProcess("sysctl", "machdep.cpu.brand_string", workingDirectory: null, env: null, out var stdOut);
255+
thisBuildActions.RunProcess("sysctl", "machdep.cpu.brand_string", workingDirectory: null, env: null, out var stdOut);
256256
return stdOut?.Any(s => s?.ToLowerInvariant().Contains("apple") == true) ?? false;
257257
}
258258
catch (Exception)

csharp/autobuilder/Semmle.Autobuild.Shared/MsBuildRule.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,12 @@ internal static class MsBuildCommandExtensions
1515
/// <returns></returns>
1616
public static CommandBuilder MsBuildCommand(this CommandBuilder cmdBuilder, IAutobuilder<AutobuildOptionsShared> builder)
1717
{
18-
var IsRunningOnAppleSiliconMac = builder.Actions.IsMacOs() && builder.Actions.IsRunningOnAppleSilicon();
19-
2018
// mono doesn't ship with `msbuild` on Arm-based Macs, but we can fall back to
2119
// msbuild that ships with `dotnet` which can be invoked with `dotnet msbuild`
2220
// perhaps we should do this on all platforms?
23-
return IsRunningOnAppleSiliconMac ?
24-
cmdBuilder.RunCommand("dotnet").Argument("msbuild") :
25-
cmdBuilder.RunCommand("msbuild");
21+
return builder.Actions.IsRunningOnAppleSilicon()
22+
? cmdBuilder.RunCommand("dotnet").Argument("msbuild")
23+
: cmdBuilder.RunCommand("msbuild");
2624
}
2725
}
2826

0 commit comments

Comments
 (0)