Skip to content

Commit 5cc94e1

Browse files
committed
Express.js: add req.path as remote input source
1 parent 21b7a51 commit 5cc94e1

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

javascript/ql/lib/semmle/javascript/frameworks/Express.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -618,6 +618,10 @@ module Express {
618618
or
619619
kind = "body" and
620620
this = ref.getAPropertyRead("body")
621+
or
622+
// `req.path`
623+
kind = "url" and
624+
this = ref.getAPropertyRead("path")
621625
)
622626
}
623627

javascript/ql/test/library-tests/frameworks/Express/tests.expected

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,6 +1109,7 @@ test_RequestInputAccess
11091109
| src/express.js:55:12:55:25 | req.params.foo | parameter | src/express.js:53:23:57:1 | functio ... res);\\n} |
11101110
| src/express.js:61:12:61:25 | req.params.foo | parameter | src/express.js:59:23:63:1 | functio ... res);\\n} |
11111111
| src/express.js:67:12:67:25 | req.params.foo | parameter | src/express.js:65:27:69:1 | functio ... res);\\n} |
1112+
| src/express.js:73:12:73:19 | req.path | url | src/express.js:71:23:75:1 | functio ... res);\\n} |
11121113
| src/inheritedFromNode.js:7:2:7:8 | req.url | url | src/inheritedFromNode.js:4:15:8:1 | functio ... .url;\\n} |
11131114
| src/params.js:4:35:4:39 | value | parameter | src/params.js:4:18:12:1 | (req, r ... }\\n} |
11141115
| src/params.js:5:17:5:28 | req.query.xx | parameter | src/params.js:4:18:12:1 | (req, r ... }\\n} |

0 commit comments

Comments
 (0)