Skip to content

Commit 5cf7c83

Browse files
committed
Go: AuthCookie/CookieWithoutHttpOnly/BoolToGin
1 parent 9dbb9e1 commit 5cf7c83

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

go/ql/src/experimental/CWE-1004/AuthCookie.qll

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -118,16 +118,10 @@ private module BoolToGinSetCookieTrackingConfig implements DataFlow::ConfigSig {
118118
}
119119

120120
predicate observeDiffInformedIncrementalMode() {
121-
any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 97 (/Users/d10c/src/semmle-code/ql/go/ql/src/experimental/CWE-1004/CookieWithoutHttpOnly.ql@99:8:99:21)
121+
any() // Merged with other flows in CookieWithoutHttpOnly.ql
122122
}
123123

124-
Location getASelectedSourceLocation(DataFlow::Node source) {
125-
none() // TODO: Make sure that this source location matches the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 97 (/Users/d10c/src/semmle-code/ql/go/ql/src/experimental/CWE-1004/CookieWithoutHttpOnly.ql@99:8:99:21)
126-
}
127-
128-
Location getASelectedSinkLocation(DataFlow::Node sink) {
129-
none() // TODO: Make sure that this sink location matches the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 97 (/Users/d10c/src/semmle-code/ql/go/ql/src/experimental/CWE-1004/CookieWithoutHttpOnly.ql@99:8:99:21)
130-
}
124+
Location getASelectedSourceLocation(DataFlow::Node source) { none() }
131125
}
132126

133127
/**

0 commit comments

Comments
 (0)