Skip to content

Commit 5eb9a53

Browse files
committed
C#: Remove disposal test for library code as we are no longer doing CIL extraction or data flow.
1 parent 72c7024 commit 5eb9a53

File tree

4 files changed

+0
-46
lines changed

4 files changed

+0
-46
lines changed

csharp/ql/test/query-tests/API Abuse/NoDisposeCallOnLocalIDisposable/Class1.cs_

Lines changed: 0 additions & 42 deletions
This file was deleted.

csharp/ql/test/query-tests/API Abuse/NoDisposeCallOnLocalIDisposable/NoDisposeCallOnLocalIDisposable.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,6 @@ public IDisposable Method()
7676
var xmlDoc = new XmlDocument();
7777
xmlDoc.Load(xmlReader);
7878

79-
// GOOD: Passed to a library (False positive as this is disposed in library code).
80-
DisposalTests.Class1.Dispose(new StreamWriter("output.txt"));
81-
8279
// GOOD: Disposed automatically.
8380
using var c2 = new Timer(TimerProc);
8481

csharp/ql/test/query-tests/API Abuse/NoDisposeCallOnLocalIDisposable/NoDisposeCallOnLocalIDisposable.expected

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@
33
| NoDisposeCallOnLocalIDisposable.cs:53:9:53:64 | object creation of type FileStream | Disposable 'FileStream' is created but not disposed. |
44
| NoDisposeCallOnLocalIDisposable.cs:75:25:75:71 | call to method Create | Disposable 'XmlReader' is created but not disposed. |
55
| NoDisposeCallOnLocalIDisposable.cs:75:42:75:64 | object creation of type StringReader | Disposable 'StringReader' is created but not disposed. |
6-
| NoDisposeCallOnLocalIDisposable.cs:80:38:80:67 | object creation of type StreamWriter | Disposable 'StreamWriter' is created but not disposed. |
76
| NoDisposeCallOnLocalIDisposableBad.cs:8:22:8:56 | object creation of type FileStream | Disposable 'FileStream' is created but not disposed. |

0 commit comments

Comments
 (0)