Skip to content

Commit 5ec3335

Browse files
committed
Java: Reword recommendation section of XXE query
1 parent 84e412f commit 5ec3335

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

java/ql/src/Security/CWE/CWE-611/XXE.qhelp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,9 @@ This improves security but the code will still be at risk of denial of service a
2828
Protection against denial of service attacks may also be implemented by setting entity expansion limits, which is done
2929
by default in recent JDK and JRE implementations.
3030

31-
Because there are many different ways to disable external entity retrieval with varying support between different providers,
32-
in this query we choose to specifically check for the <a href="https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html#java">OWASP recommended way</a>
33-
to disable external entity retrieval for a particular parser. There may be other ways of making a particular parser safe
34-
which deviate from these guidelines, in which case this query will continue to flag the parser as potentially dangerous.
31+
We recommend visiting OWASP's <a href="https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html#java">XML Entity Prevention Cheat Sheet</a>,
32+
finding the specific XML parser, and applying the mitigation listed there. Other mitigations might be sufficient in some cases, but manual verification will be needed,
33+
as the query will continue to flag the parser as potentially dangerous.
3534
</p>
3635
</recommendation>
3736

0 commit comments

Comments
 (0)