Skip to content

Commit 609d601

Browse files
authored
Merge pull request #7229 from smowton/smowton/admin/document-xxe-sanitisation-policy
Document XXE sanitisation policy
2 parents d3da790 + 120f204 commit 609d601

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

java/ql/src/Security/CWE/CWE-611/XXE.qhelp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ If this is not possible you should disable the parsing of external general entit
2727
This improves security but the code will still be at risk of denial of service and server side request forgery attacks.
2828
Protection against denial of service attacks may also be implemented by setting entity expansion limits, which is done
2929
by default in recent JDK and JRE implementations.
30+
31+
Because there are many different ways to disable external entity retrieval with varying support between different providers,
32+
in this query we choose to specifically check for the <a href="https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html#java">OWASP recommended way</a>
33+
to disable external entity retrieval for a particular parser. There may be other ways of making a particular parser safe
34+
which deviate from these guidelines, in which case this query will continue to flag the parser as potentially dangerous.
3035
</p>
3136
</recommendation>
3237

0 commit comments

Comments
 (0)