Rust: Simplify QL slightly.

geoffw0 · geoffw0 · commit 613a1656f3cb · 2025-01-23T18:13:59.000Z
diff --git a/rust/ql/src/queries/security/CWE-312/CleartextLogging.ql b/rust/ql/src/queries/security/CWE-312/CleartextLogging.ql
@@ -38,8 +38,7 @@ module CleartextLoggingConfig implements DataFlow::ConfigSig {
 
   predicate isAdditionalFlowStep(Node node1, Node node2) {
     // flow from `a` to `&a`
-    node2.(Node::ExprNode).asExpr().getExpr().(RefExpr).getExpr() =
-      node1.(Node::ExprNode).asExpr().getExpr()
+    node2.asExpr().getExpr().(RefExpr).getExpr() = node1.asExpr().getExpr()
   }
 
   predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet c) {

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,7 @@ module CleartextLoggingConfig implements DataFlow::ConfigSig {`
`38`	`38`
`39`	`39`	`predicate isAdditionalFlowStep(Node node1, Node node2) {`
`40`	`40`	// flow from `a` to `&a`
`41`		`- node2.(Node::ExprNode).asExpr().getExpr().(RefExpr).getExpr() =`
`42`		`- node1.(Node::ExprNode).asExpr().getExpr()`
	`41`	`+ node2.asExpr().getExpr().(RefExpr).getExpr() = node1.asExpr().getExpr()`
`43`	`42`	`}`
`44`	`43`
`45`	`44`	`predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet c) {`