QL: Add filter for NewType to camel case query

Author: jketema

ql/ql/src/codeql_ql/style/AcronymsShouldBeCamelCaseQuery.qll

@@ -68,5 +68,6 @@ predicate shouldBePascalCased(string name, AstNode node, string kind) {
   // allowed upper-case acronyms.
   not name.regexpMatch(".*(PEP|AES|DES|EOF).*") and
   not (name.regexpMatch("T[A-Z]{3}[^A-Z].*") and node instanceof NewTypeBranch) and
+  not (name.regexpMatch("T[A-Z]{3}[^A-Z].*") and node instanceof NewType) and
   not name.toUpperCase() = name // We are OK with fully-uppercase names.
 }

ql/ql/test/queries/style/AcronymsShouldBeCamelCase/AcronymsShouldBeCamelCase.expected

@@ -1,4 +1,3 @@
 | Test.qll:2:1:2:27 | ClasslessPredicate isXML | Acronyms in isXML should be PascalCase/camelCase |
 | Test.qll:8:1:10:15 | NewType TXMLElements | Acronyms in TXMLElements should be PascalCase/camelCase |
 | Test.qll:10:3:10:15 | NewTypeBranch TXMLElement | Acronyms in TXMLElement should be PascalCase/camelCase |
-| Test.qll:13:1:14:16 | NewType TIRFunction | Acronyms in TIRFunction should be PascalCase/camelCase |

ql/ql/test/queries/style/AcronymsShouldBeCamelCase/Test.qll

@@ -9,6 +9,6 @@ newtype TXMLElements =
   TXmlElement() or // GOOD
   TXMLElement() // BAD
 
-// GOOD [ FALSE POSITIVE ]
+// GOOD
 newtype TIRFunction =
   MkIRFunction()