Skip to content

Commit 64db70f

Browse files
committed
JS: Add explicit body-parsers to TemplateObjectInjection test
1 parent 8af430d commit 64db70f

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

javascript/ql/test/query-tests/Security/CWE-073/tst.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
var app = require('express')();
22
app.set('view engine', 'hbs');
33

4-
5-
4+
app.use(require('body-parser').json());
5+
app.use(require('body-parser').urlencoded({ extended: false }));
66
app.post('/path', function(req, res) {
77
var bodyParameter = req.body.bodyParameter;
88
var queryParameter = req.query.queryParameter;

javascript/ql/test/query-tests/Security/CWE-073/tst2.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,43 +2,43 @@ const handlebars = require("express-handlebars");
22
var app = require('express')();
33
app.engine( '.hbs', handlebars({ defaultLayout: 'main', extname: '.hbs' }) );
44
app.set('view engine', '.hbs')
5-
app.post('/path', function(req, res) {
5+
app.post('/path', require('body-parser').json(), function(req, res) {
66
var bodyParameter = req.body.bodyParameter;
77
res.render('template', bodyParameter); // NOT OK
88
});
99

1010
var app2 = require('express')();
11-
app2.post('/path', function(req, res) {
11+
app2.post('/path', require('body-parser').json(), function(req, res) {
1212
var bodyParameter = req.body.bodyParameter;
1313
res.render('template', bodyParameter); // OK
1414
});
1515

1616
var app3 = require('express')();
1717
app3.set('view engine', 'pug');
18-
app3.post('/path', function(req, res) {
18+
app3.post('/path', require('body-parser').json(), function(req, res) {
1919
var bodyParameter = req.body.bodyParameter;
2020
res.render('template', bodyParameter); // OK
2121
});
2222

2323
var app4 = require('express')();
2424
app4.set('view engine', 'ejs');
25-
app4.post('/path', function(req, res) {
25+
app4.post('/path', require('body-parser').json(), function(req, res) {
2626
var bodyParameter = req.body.bodyParameter;
2727
res.render('template', bodyParameter); // NOT OK
2828
});
2929

3030
var app5 = require('express')();
3131
app5.engine("foobar", require("consolidate").whiskers);
3232
app5.set('view engine', 'foobar');
33-
app5.post('/path', function(req, res) {
33+
app5.post('/path', require('body-parser').json(), function(req, res) {
3434
var bodyParameter = req.body.bodyParameter;
3535
res.render('template', bodyParameter); // NOT OK
3636
});
3737

3838
var app6 = require('express')();
3939
app6.register(".html", require("consolidate").whiskers);
4040
app6.set('view engine', 'html');
41-
app6.post('/path', function(req, res) {
41+
app6.post('/path', require('body-parser').json(), function(req, res) {
4242
var bodyParameter = req.body.bodyParameter;
4343
res.render('template', bodyParameter); // NOT OK
4444
});
@@ -47,7 +47,7 @@ const express = require('express');
4747
var router = express.Router();
4848
var app7 = express();
4949
app7.set('view engine', 'ejs');
50-
router.post('/path', function(req, res) {
50+
router.post('/path', require('body-parser').json(), function(req, res) {
5151
var bodyParameter = req.body.bodyParameter;
5252
res.render('template', bodyParameter); // NOT OK
5353
});

0 commit comments

Comments
 (0)