Skip to content

Commit 6538d22

Browse files
Fix tornado model of httheaders.add.
1 parent 0901b3d commit 6538d22

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

python/ql/lib/semmle/python/frameworks/Tornado.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ module Tornado {
9595
private class TornadoHeadersAppendCall extends Http::Server::ResponseHeaderWrite::Range,
9696
DataFlow::MethodCallNode
9797
{
98-
TornadoHeadersAppendCall() { this.calls(instance(), "append") }
98+
TornadoHeadersAppendCall() { this.calls(instance(), "add") }
9999

100100
override DataFlow::Node getNameArg() { result = [this.getArg(0), this.getArgByName("name")] }
101101

python/ql/test/library-tests/frameworks/tornado/response_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def get(self): # $ requestHandler
6969
self.set_cookie(name="key", value="value") # $ CookieWrite CookieName="key" CookieValue="value"
7070
self.set_header("Set-Cookie", "key2=value2") # $ headerWriteName="Set-Cookie" headerWriteValue="key2=value2" CookieWrite CookieRawHeader="key2=value2"
7171
self.add_header("Set-Cookie", "key3=value3") # $ headerWriteName="Set-Cookie" headerWriteValue="key3=value3" CookieWrite CookieRawHeader="key3=value3"
72-
self.request.headers.append("Set-Cookie", "key4=value4") # $ headerWriteName="Set-Cookie" headerWriteValue="key4=value4" CookieWrite CookieRawHeader="key4=value4"
72+
self.request.headers.add("Set-Cookie", "key4=value4") # $ headerWriteName="Set-Cookie" headerWriteValue="key4=value4" CookieWrite CookieRawHeader="key4=value4"
7373
self.request.headers["Set-Cookie"] = "key5=value5" # $ headerWriteName="Set-Cookie" headerWriteValue="key5=value5" CookieWrite CookieRawHeader="key5=value5"
7474

7575

0 commit comments

Comments
 (0)