Skip to content

Commit 655f079

Browse files
committed
Swift: fix legacy extractor-pack-arch target
1 parent 2606d3f commit 655f079

File tree

3 files changed

+26
-5
lines changed

3 files changed

+26
-5
lines changed

swift/BUILD.bazel

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup")
2+
load("//:defs.bzl", "codeql_platform")
23
load(
34
"//misc/bazel:pkg.bzl",
45
"codeql_pack",
@@ -91,15 +92,28 @@ alias(
9192
actual = ":swift-installer",
9293
)
9394

94-
# TODO: aliases for internal repo backward compatibility
95+
# TODO: following rules are for internal repo backward compatibility only
9596
alias(
9697
name = "extractor-pack-generic",
9798
actual = "swift-generic",
9899
visibility = ["//visibility:public"],
99100
)
100101

101-
alias(
102+
pkg_filegroup(
103+
name = "resource-dir",
104+
srcs = select({
105+
"@platforms//os:linux": ["@swift_toolchain_linux//:resource-dir-files"],
106+
"@platforms//os:macos": ["@swift_toolchain_macos//:resource-dir-files"],
107+
"@platforms//os:windows": [],
108+
}),
109+
prefix = "resource-dir/" + codeql_platform,
110+
)
111+
112+
pkg_filegroup(
102113
name = "extractor-pack-arch",
103-
actual = "swift-arch",
114+
srcs = [
115+
":resource-dir",
116+
":swift-arch",
117+
],
104118
visibility = ["//visibility:public"],
105119
)

swift/third_party/BUILD.swift-toolchain-linux.bazel

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@rules_pkg//pkg:mappings.bzl", "pkg_files")
1+
load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files")
22
load("@rules_pkg//pkg:pkg.bzl", "pkg_zip")
33

44
_strip_prefix = "usr/lib/swift"
@@ -43,9 +43,15 @@ _pm_interface_files = [
4343
for dir, interface, module in _pm_interface_files
4444
]
4545

46+
pkg_filegroup(
47+
name = "resource-dir-files",
48+
srcs = [":resource-dir-original"] + [":pkg-%s" % module for _, _, module in _pm_interface_files],
49+
visibility = ["//visibility:public"],
50+
)
51+
4652
pkg_zip(
4753
name = "resource-dir-linux",
48-
srcs = [":resource-dir-original"] + [":pkg-%s" % module for _, _, module in _pm_interface_files],
54+
srcs = [":resource-dir-files"],
4955
)
5056

5157
alias(

swift/third_party/BUILD.swift-toolchain-macos.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ pkg_files(
99
["usr/lib/swift/**/*"],
1010
),
1111
strip_prefix = _strip_prefix,
12+
visibility = ["//visibility:public"],
1213
)
1314

1415
pkg_zip(

0 commit comments

Comments
 (0)