Skip to content

Commit 65fafbf

Browse files
committed
C++: Fix QL-for-QL warnings
1 parent 084dbc4 commit 65fafbf

File tree

7 files changed

+6
-13
lines changed

7 files changed

+6
-13
lines changed

cpp/ql/src/experimental/Security/CWE/CWE-409/Brotli.qll

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,13 @@
33
*/
44

55
import cpp
6-
import semmle.code.cpp.ir.dataflow.TaintTracking
76
import DecompressionBomb
87

98
/**
109
* The `BrotliDecoderDecompress` function is used in flow sink. * Ref: https://www.brotli.org/decode.html#af68
1110
*/
1211
class BrotliDecoderDecompressFunction extends DecompressionFunction {
13-
BrotliDecoderDecompressFunction() { this.hasGlobalName(["BrotliDecoderDecompress"]) }
12+
BrotliDecoderDecompressFunction() { this.hasGlobalName("BrotliDecoderDecompress") }
1413

1514
override int getArchiveParameterIndex() { result = 1 }
1615
}
@@ -19,7 +18,7 @@ class BrotliDecoderDecompressFunction extends DecompressionFunction {
1918
* The `BrotliDecoderDecompressStream` function is used in flow sink. * Ref: https://www.brotli.org/decode.html#a234
2019
*/
2120
class BrotliDecoderDecompressStreamFunction extends DecompressionFunction {
22-
BrotliDecoderDecompressStreamFunction() { this.hasGlobalName(["BrotliDecoderDecompressStream"]) }
21+
BrotliDecoderDecompressStreamFunction() { this.hasGlobalName("BrotliDecoderDecompressStream") }
2322

2423
override int getArchiveParameterIndex() { result = 2 }
2524
}

cpp/ql/src/experimental/Security/CWE/CWE-409/LibArchive.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
*/
44

55
import cpp
6-
import semmle.code.cpp.ir.dataflow.TaintTracking
76
import DecompressionBomb
87

98
/**

cpp/ql/src/experimental/Security/CWE/CWE-409/MiniZip.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
*/
44

55
import cpp
6-
import semmle.code.cpp.ir.dataflow.TaintTracking
76
import DecompressionBomb
87

98
/**

cpp/ql/src/experimental/Security/CWE/CWE-409/ZSTD.qll

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,13 @@
33
*/
44

55
import cpp
6-
import semmle.code.cpp.ir.dataflow.TaintTracking
76
import DecompressionBomb
87

98
/**
109
* The `ZSTD_decompress` function is used in flow sink.
1110
*/
1211
class ZstdDecompressFunction extends DecompressionFunction {
13-
ZstdDecompressFunction() { this.hasGlobalName(["ZSTD_decompress"]) }
12+
ZstdDecompressFunction() { this.hasGlobalName("ZSTD_decompress") }
1413

1514
override int getArchiveParameterIndex() { result = 2 }
1615
}
@@ -19,7 +18,7 @@ class ZstdDecompressFunction extends DecompressionFunction {
1918
* The `ZSTD_decompressDCtx` function is used in flow sink.
2019
*/
2120
class ZstdDecompressDctxFunction extends DecompressionFunction {
22-
ZstdDecompressDctxFunction() { this.hasGlobalName(["ZSTD_decompressDCtx"]) }
21+
ZstdDecompressDctxFunction() { this.hasGlobalName("ZSTD_decompressDCtx") }
2322

2423
override int getArchiveParameterIndex() { result = 3 }
2524
}
@@ -28,7 +27,7 @@ class ZstdDecompressDctxFunction extends DecompressionFunction {
2827
* The `ZSTD_decompressStream` function is used in flow sink.
2928
*/
3029
class ZstdDecompressStreamFunction extends DecompressionFunction {
31-
ZstdDecompressStreamFunction() { this.hasGlobalName(["ZSTD_decompressStream"]) }
30+
ZstdDecompressStreamFunction() { this.hasGlobalName("ZSTD_decompressStream") }
3231

3332
override int getArchiveParameterIndex() { result = 2 }
3433
}
@@ -37,7 +36,7 @@ class ZstdDecompressStreamFunction extends DecompressionFunction {
3736
* The `ZSTD_decompress_usingDDict` function is used in flow sink.
3837
*/
3938
class ZstdDecompressUsingDdictFunction extends DecompressionFunction {
40-
ZstdDecompressUsingDdictFunction() { this.hasGlobalName(["ZSTD_decompress_usingDDict"]) }
39+
ZstdDecompressUsingDdictFunction() { this.hasGlobalName("ZSTD_decompress_usingDDict") }
4140

4241
override int getArchiveParameterIndex() { result = 3 }
4342
}

cpp/ql/src/experimental/Security/CWE/CWE-409/ZlibGzopen.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
*/
44

55
import cpp
6-
import semmle.code.cpp.ir.dataflow.TaintTracking
76
import DecompressionBomb
87

98
/**

cpp/ql/src/experimental/Security/CWE/CWE-409/ZlibInflator.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
*/
44

55
import cpp
6-
import semmle.code.cpp.ir.dataflow.TaintTracking
76
import DecompressionBomb
87

98
/**

cpp/ql/src/experimental/Security/CWE/CWE-409/ZlibUncompress.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
*/
44

55
import cpp
6-
import semmle.code.cpp.ir.dataflow.TaintTracking
76
import DecompressionBomb
87

98
/**

0 commit comments

Comments
 (0)