Skip to content

Commit 6613a98

Browse files
committed
Fix references to logging library
1 parent ea7e259 commit 6613a98

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

java/ql/lib/semmle/code/java/frameworks/Logging.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ private class LoggingSinkModels extends SinkModelCsv {
208208
";(String,Object,Object,Object,Object);;Argument[0..4];logging",
209209
";(Throwable,String,Object);;Argument[1..2];logging",
210210
";(Throwable,String,Object,Object);;Argument[1..3];logging",
211-
";(Throwable,String,Object,Object,Object);;Argument[0..4];logging",
211+
";(Throwable,String,Object,Object,Object);;Argument[0..4];logging"
212212
],
213213
jBossLogger() + ";true;log" + ["f", "v"] +
214214
[

java/ql/src/experimental/Security/CWE/CWE-348/ClientSuppliedIpUsedInSecurityCheckLib.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import java
22
import DataFlow
33
import semmle.code.java.frameworks.Networking
44
import semmle.code.java.security.QueryInjection
5-
import experimental.semmle.code.java.Logging
65

76
/**
87
* A data flow source of the client ip obtained according to the remote endpoint identifier specified

java/ql/src/experimental/Security/CWE/CWE-532/SensitiveInfoLog.ql

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
*/
1212

1313
import java
14+
import semmle.code.java.dataflow.ExternalFlow
1415
import semmle.code.java.dataflow.TaintTracking
1516
import semmle.code.java.security.SensitiveActions
16-
import experimental.semmle.code.java.Logging
1717
import DataFlow
1818
import PathGraph
1919

@@ -36,9 +36,7 @@ class LoggerConfiguration extends DataFlow::Configuration {
3636

3737
override predicate isSource(DataFlow::Node source) { source.asExpr() instanceof CredentialExpr }
3838

39-
override predicate isSink(DataFlow::Node sink) {
40-
exists(LoggingCall c | sink.asExpr() = c.getALogArgument())
41-
}
39+
override predicate isSink(DataFlow::Node sink) { sinkNode(sink, "logging") }
4240

4341
override predicate isAdditionalFlowStep(DataFlow::Node node1, DataFlow::Node node2) {
4442
TaintTracking::localTaintStep(node1, node2)

0 commit comments

Comments
 (0)