Update kind model validation

GeekMasher · GeekMasher · commit 681623d631f2 · 2023-05-10T10:06:22.000+01:00
diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlow.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlow.qll
@@ -211,7 +211,11 @@ module ModelValidation {
     )
     or
     exists(string kind | sinkModel(_, _, _, _, _, _, _, kind, _) |
-      not kind = ["code", "sql", "xss", "remote", "html"] and
+      not kind =
+        [
+          "code", "command-injection", "html", "ldap-injection", "log-injection", "remote", "sql",
+          "url-redirection", "xss",
+        ] and
       not kind.matches("encryption-%") and
       result = "Invalid kind \"" + kind + "\" in sink model."
     )

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,11 @@ module ModelValidation {`
`211`	`211`	`)`
`212`	`212`	`or`
`213`	`213`	`exists(string kind \| sinkModel(_, _, _, _, _, _, _, kind, _) \|`
`214`		`- not kind = ["code", "sql", "xss", "remote", "html"] and`
	`214`	`+ not kind =`
	`215`	`+ [`
	`216`	`+ "code", "command-injection", "html", "ldap-injection", "log-injection", "remote", "sql",`
	`217`	`+ "url-redirection", "xss",`
	`218`	`+ ] and`
`215`	`219`	`not kind.matches("encryption-%") and`
`216`	`220`	`result = "Invalid kind \"" + kind + "\" in sink model."`
`217`	`221`	`)`