Skip to content

Commit 6a2346e

Browse files
Clean up sink definition
1 parent daf6ac2 commit 6a2346e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

java/ql/src/semmle/code/java/security/AndroidSensitiveBroadcastQuery.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ private predicate isEmptyArrayArg(Expr ex) {
5555
*/
5656
private predicate isSensitiveBroadcastSink(DataFlow::Node sink) {
5757
exists(SendBroadcastMethodAccess ma, string name | ma.getMethod().hasName(name) |
58-
sink.asExpr() = ma.getAnArgument() and
58+
sink.asExpr() = ma.getArgument(0) and
5959
(
6060
name = "sendBroadcast" and
6161
(
@@ -85,7 +85,7 @@ private predicate isSensitiveBroadcastSink(DataFlow::Node sink) {
8585
// sendOrderedBroadcast(Intent intent, String receiverPermission)
8686
// sendOrderedBroadcast(Intent intent, String receiverPermission, BroadcastReceiver resultReceiver, Handler scheduler, int initialCode, String initialData, Bundle initialExtras)
8787
isNullArg(ma.getArgument(1)) and
88-
ma.getNumArgument() <= 7
88+
ma.getNumArgument() = [2, 7]
8989
or
9090
// sendOrderedBroadcast(Intent intent, String receiverPermission, String receiverAppOp, BroadcastReceiver resultReceiver, Handler scheduler, int initialCode, String initialData, Bundle initialExtras)
9191
isNullArg(ma.getArgument(1)) and

0 commit comments

Comments
 (0)