Go: ReflectedXss

d10c · d10c · commit 6aea7914c547 · 2025-07-07T11:39:52.000+02:00
diff --git a/go/ql/lib/semmle/go/security/ReflectedXss.qll b/go/ql/lib/semmle/go/security/ReflectedXss.qll
@@ -23,8 +23,12 @@ module ReflectedXss {
 
     predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }
 
-    predicate observeDiffInformedIncrementalMode() {
-      any() // TODO: Make sure that the location overrides match the query's select clause: Column 7 selects sink.getAssociatedLoc (/Users/d10c/src/semmle-code/ql/go/ql/src/Security/CWE-079/ReflectedXss.ql@36:84:36:90)
+    predicate observeDiffInformedIncrementalMode() { any() }
+
+    Location getASelectedSinkLocation(DataFlow::Node sink) {
+      result = sink.getLocation()
+      or
+      result = sink.(SharedXss::Sink).getAssociatedLoc().getLocation()
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,12 @@ module ReflectedXss {`
`23`	`23`
`24`	`24`	`predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }`
`25`	`25`
`26`		`- predicate observeDiffInformedIncrementalMode() {`
`27`		`- any() // TODO: Make sure that the location overrides match the query's select clause: Column 7 selects sink.getAssociatedLoc (/Users/d10c/src/semmle-code/ql/go/ql/src/Security/CWE-079/ReflectedXss.ql@36:84:36:90)`
	`26`	`+ predicate observeDiffInformedIncrementalMode() { any() }`
	`27`	`+`
	`28`	`+ Location getASelectedSinkLocation(DataFlow::Node sink) {`
	`29`	`+ result = sink.getLocation()`
	`30`	`+ or`
	`31`	`+ result = sink.(SharedXss::Sink).getAssociatedLoc().getLocation()`
`28`	`32`	`}`
`29`	`33`	`}`
`30`	`34`