Skip to content

Commit 6cda285

Browse files
committed
Refactor Guice test
1 parent 8d0e3ac commit 6cda285

File tree

1 file changed

+7
-7
lines changed
  • java/ql/test/library-tests/frameworks/guice

1 file changed

+7
-7
lines changed

java/ql/test/library-tests/frameworks/guice/flow.ql

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,10 @@ import java
22
import semmle.code.java.dataflow.FlowSources
33
import semmle.code.java.dataflow.TaintTracking
44

5-
class Conf extends TaintTracking::Configuration {
6-
Conf() { this = "conf" }
5+
module Config implements DataFlow::ConfigSig {
6+
predicate isSource(DataFlow::Node src) { src instanceof RemoteFlowSource }
77

8-
override predicate isSource(DataFlow::Node src) { src instanceof RemoteFlowSource }
9-
10-
override predicate isSink(DataFlow::Node sink) {
8+
predicate isSink(DataFlow::Node sink) {
119
exists(MethodAccess ma |
1210
sink.asExpr() = ma.getAnArgument() and
1311
ma.getMethod().hasName("sink")
@@ -16,6 +14,8 @@ class Conf extends TaintTracking::Configuration {
1614
}
1715
}
1816

19-
from Conf c, DataFlow::Node src, DataFlow::Node sink
20-
where c.hasFlow(src, sink)
17+
module Flow = TaintTracking::Global<Config>;
18+
19+
from DataFlow::Node src, DataFlow::Node sink
20+
where Flow::flow(src, sink)
2121
select src, sink

0 commit comments

Comments
 (0)