Skip to content

Commit 6f79480

Browse files
committed
C#: Add example of missing sink generation.
1 parent a782952 commit 6f79480

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

csharp/ql/test/utils/modelgenerator/dataflow/CaptureSinkModels.ext.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ extensions:
66
- [ "Sinks", "NewSinks", False, "Sink", "(System.Object)", "", "Argument[0]", "test-sink", "manual"]
77
- [ "Sinks", "NewSinks", False, "Sink2", "(System.Object)", "", "Argument[0]", "test-sink2", "manual"]
88
- [ "Sinks", "NewSinks", False, "ManualSinkAlreadyDefined", "(System.Object)", "", "Argument[0]", "test-sink", "manual"]
9+
- [ "Sinks", "NewSinks", False, "SaveAndGet", "(System.Object)", "", "Argument[0]", "test-sink", "df-generated"]
10+
11+
- addsTo:
12+
pack: codeql/csharp-all
13+
extensible: sourceModel
14+
data:
15+
- [ "Sinks", "NewSinks", False, "SaveAndGet", "(System.Object)", "", "ReturnValue", "test-source", "manual"]
916

1017
- addsTo:
1118
pack: codeql/csharp-all

csharp/ql/test/utils/modelgenerator/dataflow/Sinks.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,15 @@ public class NewSinks
2424
// neutral=Sinks;NewSinks;NoSink;(System.Object);summary;df-generated
2525
public static void NoSink(object o) => throw null;
2626

27+
// Sink and Source defined in the extensible file next to the sink test.
28+
// MISSING SINK
29+
// neutral=Sinks;NewSinks;SaveAndGet;(System.Object);summary;df-generated
30+
public static object SaveAndGet(object o)
31+
{
32+
Sink(o);
33+
return null;
34+
}
35+
2736
// New sink
2837
// sink=Sinks;NewSinks;false;WrapResponseWrite;(System.Object);;Argument[0];html-injection;df-generated
2938
// neutral=Sinks;NewSinks;WrapResponseWrite;(System.Object);summary;df-generated

0 commit comments

Comments
 (0)